IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

WebhookNotifier: Convert tests away from goconvey (#29291)

Browse Source 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Arve Knudsen 2020-11-23 10:37:53 +01:00 committed by GitHub
parent 81859880d3
commit 063f863abc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
pkg/services/alerting/notifiers/webhook_test.go
View File

@ -5,33 +5,31 @@ import (
"github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/components/simplejson"
"github.com/grafana/grafana/pkg/models" "github.com/grafana/grafana/pkg/models"
. "github.com/smartystreets/goconvey/convey" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
) )
func TestWebhookNotifier(t *testing.T) { func TestWebhookNotifier_parsingFromSettings(t *testing.T) {
Convey("Webhook notifier tests", t, func() { t.Run("Empty settings should cause error", func(t *testing.T) {
Convey("Parsing alert notification from settings", func() { const json = `{}`
Convey("empty settings should return error", func() {
json := `{ }`
settingsJSON, _ := simplejson.NewJson([]byte(json)) settingsJSON, err := simplejson.NewJson([]byte(json))
require.NoError(t, err)
model := &models.AlertNotification{ model := &models.AlertNotification{
Name: "ops", Name: "ops",
Type: "webhook", Type: "webhook",
Settings: settingsJSON, Settings: settingsJSON,
} }
_, err := NewWebHookNotifier(model) _, err = NewWebHookNotifier(model)
So(err, ShouldNotBeNil) require.Error(t, err)
}) })
Convey("from settings", func() { t.Run("Valid settings should result in a valid notifier", func(t *testing.T) {
json := ` const json = `{"url": "http://google.com"}`
{
"url": "http://google.com"
}`
settingsJSON, _ := simplejson.NewJson([]byte(json)) settingsJSON, err := simplejson.NewJson([]byte(json))
require.NoError(t, err)
model := &models.AlertNotification{ model := &models.AlertNotification{
Name: "ops", Name: "ops",
Type: "webhook", Type: "webhook",
@ -39,13 +37,11 @@ func TestWebhookNotifier(t *testing.T) {
} }
not, err := NewWebHookNotifier(model) not, err := NewWebHookNotifier(model)
require.NoError(t, err)
webhookNotifier := not.(*WebhookNotifier) webhookNotifier := not.(*WebhookNotifier)
So(err, ShouldBeNil) assert.Equal(t, "ops", webhookNotifier.Name)
So(webhookNotifier.Name, ShouldEqual, "ops") assert.Equal(t, "webhook", webhookNotifier.Type)
So(webhookNotifier.Type, ShouldEqual, "webhook") assert.Equal(t, "http://google.com", webhookNotifier.URL)
So(webhookNotifier.URL, ShouldEqual, "http://google.com")
})
})
}) })
} }