IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-09-05 04:40:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Move function calls w/ side-effects to componentDidMount

Browse Source 
* loadStore() modified the url which triggered a new render path, this
gets noticed by react. Moved to componentDidMount.
This commit is contained in:
David Kaltschmidt
2018-04-24 12:07:24 +02:00
parent cc5d7002b0
commit 0695e431ea
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/containers/ManageDashboards/FolderPermissions.tsx
+3
View File
@@ -16,6 +16,9 @@ export class FolderPermissions extends Component<IContainerProps, any> {
constructor(props) { constructor(props) {
super(props); super(props);
this.handleAddPermission = this.handleAddPermission.bind(this); this.handleAddPermission = this.handleAddPermission.bind(this);
}
componentDidMount() {
this.loadStore(); this.loadStore();
} }
public/app/containers/ManageDashboards/FolderSettings.tsx
+1 -2
View File
@@ -12,8 +12,7 @@ import appEvents from 'app/core/app_events';
export class FolderSettings extends React.Component<IContainerProps, any> { export class FolderSettings extends React.Component<IContainerProps, any> {
formSnapshot: any; formSnapshot: any;
constructor(props) { componentDidMount() {
super(props);
this.loadStore(); this.loadStore();
} }