IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Canvas: Avoid refreshing elements while dragging (#52120)

Browse Source
This commit is contained in:
Nathan Marrs 2022-07-13 08:44:43 -07:00 committed by GitHub
parent 429ed4b4ee
commit 074bcf8599
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
public/app/features/canvas/runtime/scene.tsx
View File

@ -60,6 +60,7 @@ export class Scene {
currentLayer?: FrameState;
isEditingEnabled?: boolean;
skipNextSelectionBroadcast = false;
ignoreDataUpdate = false;
isPanelEditing = locationService.getSearchObject().editPanel !== undefined;
@ -326,6 +327,12 @@ export class Scene {
.on('clickGroup', (event) => {
this.selecto!.clickTarget(event.inputEvent, event.inputTarget);
})
.on('dragStart', (event) => {
this.ignoreDataUpdate = true;
})
.on('dragGroupStart', (event) => {
this.ignoreDataUpdate = true;
})
.on('drag', (event) => {
const targetedElement = this.findElementByTarget(event.target);
targetedElement!.applyDrag(event);
@ -336,6 +343,17 @@ export class Scene {
targetedElement!.applyDrag(event);
});
})
.on('dragGroupEnd', (e) => {
e.events.forEach((event) => {
const targetedElement = this.findElementByTarget(event.target);
if (targetedElement) {
targetedElement.setPlacementFromConstraint();
}
});
this.moved.next(Date.now());
this.ignoreDataUpdate = false;
})
.on('dragEnd', (event) => {
const targetedElement = this.findElementByTarget(event.target);
if (targetedElement) {
@ -343,6 +361,7 @@ export class Scene {
}
this.moved.next(Date.now());
this.ignoreDataUpdate = false;
})
.on('resizeStart', (event) => {
const targetedElement = this.findElementByTarget(event.target);

3
public/app/plugins/panel/canvas/CanvasPanel.tsx
View File

@ -139,7 +139,8 @@ export class CanvasPanel extends Component<Props, State> {
this.scene.updateSize(nextProps.width, nextProps.height);
changed = true;
}
if (data !== nextProps.data) {
if (data !== nextProps.data && !this.scene.ignoreDataUpdate) {
this.scene.updateData(nextProps.data);
changed = true;
}