IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

FeatureFlags: Do not allow spaces in descriptions (#68852)

Browse Source
This commit is contained in:
Ryan McKinley 2023-05-23 07:42:22 -07:00 committed by GitHub
parent 900348f3d9
commit 07e794c312
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/services/featuremgmt/registry.go
View File

@ -507,7 +507,7 @@ var (
},
{
Name: "faroDatasourceSelector",
Description: "Enable the data source selector within the Frontend Apps section of the Frontend Observability ",
Description: "Enable the data source selector within the Frontend Apps section of the Frontend Observability",
State: FeatureStateBeta,
FrontendOnly: true,
Owner: appO11ySquad,

2
pkg/services/featuremgmt/toggles_gen.go
View File

@ -308,7 +308,7 @@ const (
FlagAdvancedDataSourcePicker = "advancedDataSourcePicker"
// FlagFaroDatasourceSelector
// Enable the data source selector within the Frontend Apps section of the Frontend Observability
// Enable the data source selector within the Frontend Apps section of the Frontend Observability
FlagFaroDatasourceSelector = "faroDatasourceSelector"
// FlagEnableDatagridEditing

6
pkg/services/featuremgmt/toggles_gen_test.go
View File

@ -39,6 +39,12 @@ func TestFeatureToggleFiles(t *testing.T) {
if flag.State == FeatureStateUnknown {
t.Errorf("standard toggles should not have an unknown state. See: %s", flag.Name)
}
if flag.Description != strings.TrimSpace(flag.Description) {
t.Errorf("flag Description should not start/end with spaces. See: %s", flag.Name)
}
if flag.Name != strings.TrimSpace(flag.Name) {
t.Errorf("flag Name should not start/end with spaces. See: %s", flag.Name)
}
}
})