IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-16 18:34:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

Scenes: Fix crash when searching panel options (#85180)

Browse Source 
Closes #81883
This commit is contained in:
kay delaney 2024-03-26 14:55:54 +00:00 committed by GitHub
parent b214b07695
commit 08ef6e1a42
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
public/app/features/dashboard/components/PanelEditor/getPanelFrameOptions.tsx
View File

@ -214,14 +214,7 @@ export function getPanelFrameCategory2(
value: panel.state.title,
popularRank: 1,
render: function renderTitle() {
const { title } = panel.useState();
return (
<Input
id="PanelFrameTitle"
value={title}
onChange={(e) => panel.setState({ title: e.currentTarget.value })}
/>
);
return <PanelFrameTitle panel={panel} />;
},
addon: config.featureToggles.dashgpt && (
<GenAIPanelTitleButton
@ -237,14 +230,7 @@ export function getPanelFrameCategory2(
title: 'Description',
value: panel.state.description,
render: function renderDescription() {
const { description } = panel.useState();
return (
<TextArea
id="description-text-area"
value={description}
onChange={(e) => panel.setState({ description: e.currentTarget.value })}
/>
);
return <DescriptionTextArea panel={panel} />;
},
addon: config.featureToggles.dashgpt && (
<GenAIPanelDescriptionButton
@ -369,3 +355,23 @@ function ScenePanelLinksEditor({ panelLinks }: ScenePanelLinksEditorProps) {
/>
);
}
function PanelFrameTitle({ panel }: { panel: VizPanel }) {
const { title } = panel.useState();
return (
<Input id="PanelFrameTitle" value={title} onChange={(e) => panel.setState({ title: e.currentTarget.value })} />
);
}
function DescriptionTextArea({ panel }: { panel: VizPanel }) {
const { description } = panel.useState();
return (
<TextArea
id="description-text-area"
value={description}
onChange={(e) => panel.setState({ description: e.currentTarget.value })}
/>
);
}