IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Explore: fix object value parsing for downloading traces as csv (#44492)

Browse Source 
* Explore: fix object value parsing for downloading traces as csv

Signed-off-by: tharun <rajendrantharun@live.com>

* add replacer function to fix circular objects

Signed-off-by: tharun <rajendrantharun@live.com>
This commit is contained in:
Tharun Rajendran 2022-02-24 17:15:51 +05:30 committed by GitHub
parent 85af6d2718
commit 0a572cae4b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/grafana-data/src/field/displayProcessor.test.ts
View File

@ -460,7 +460,7 @@ describe('getRawDisplayProcessor', () => {
${'a string'} | ${'a string'} ${'a string'} | ${'a string'}
${null} | ${'null'} ${null} | ${'null'}
${undefined} | ${'undefined'} ${undefined} | ${'undefined'}
${{ value: 0, label: 'a label' }} | ${'[object Object]'} ${{ value: 0, label: 'a label' }} | ${'{"value":0,"label":"a label"}'}
`('when called with value:{$value}', ({ value, expected }) => { `('when called with value:{$value}', ({ value, expected }) => {
const result = processor(value); const result = processor(value);

16
packages/grafana-data/src/field/displayProcessor.ts
View File

@ -11,6 +11,7 @@ import { KeyValue, TimeZone } from '../types';
import { getScaleCalculator } from './scale'; import { getScaleCalculator } from './scale';
import { GrafanaTheme2 } from '../themes/types'; import { GrafanaTheme2 } from '../themes/types';
import { anyToNumber } from '../utils/anyToNumber'; import { anyToNumber } from '../utils/anyToNumber';
import { getFieldTypeFromValue } from '../dataframe/processDataFrame';
interface DisplayProcessorOptions { interface DisplayProcessorOptions {
field: Partial<Field>; field: Partial<Field>;
@ -168,7 +169,20 @@ function toStringProcessor(value: any): DisplayValue {
export function getRawDisplayProcessor(): DisplayProcessor { export function getRawDisplayProcessor(): DisplayProcessor {
return (value: any) => ({ return (value: any) => ({
text: `${value}`, text: getFieldTypeFromValue(value) === 'other' ? `${JSON.stringify(value, getCircularReplacer())}` : `${value}`,
numeric: null as unknown as number, numeric: null as unknown as number,
}); });
} }
const getCircularReplacer = () => {
const seen = new WeakSet();
return (_key: any, value: object | null) => {
if (typeof value === 'object' && value !== null) {
if (seen.has(value)) {
return;
}
seen.add(value);
}
return value;
};
};