IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Convert GraphTicks test to RTL (#51203)

Browse Source 
* Convert GraphTicks test to RTL

* Convert GraphTicks test to RTL
This commit is contained in:
Seyaji 2022-06-23 08:55:38 +01:00 committed by GitHub
parent 5d74701848
commit 0b1a886b9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.betterer.results
View File

@ -29,9 +29,6 @@ exports[`no enzyme tests`] = {
"packages/grafana-ui/src/slate-plugins/suggestions.test.tsx:3654981205": [
[0, 18, 13, "RegExp match", "2409514259"]
],
"packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/GraphTicks.test.js:940336852": [
[14, 19, 13, "RegExp match", "2409514259"]
],
"packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/Scrubber.test.js:4256741694": [
[14, 19, 13, "RegExp match", "2409514259"]
],

27
packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/GraphTicks.test.js
View File

@ -12,12 +12,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.
import { shallow } from 'enzyme';
import { render, screen, within } from '@testing-library/react';
import React from 'react';
import GraphTicks from './GraphTicks';
describe('<GraphTicks>', () => {
const setup = (propOverrides) => {
const defaultProps = {
items: [
{ valueWidth: 100, valueOffset: 25, serviceName: 'a' },
@ -25,20 +25,27 @@ describe('<GraphTicks>', () => {
],
valueWidth: 200,
numTicks: 4,
...propOverrides,
};
let ticksG;
beforeEach(() => {
const wrapper = shallow(<GraphTicks {...defaultProps} />);
ticksG = wrapper.find('[data-test="ticks"]');
});
return render(
<svg>
<GraphTicks {...defaultProps} />
</svg>
);
};
describe('GraphTicks tests', () => {
it('creates a <g> for ticks', () => {
expect(ticksG.length).toBe(1);
setup();
expect(screen.getByTestId('ticks')).toBeInTheDocument();
});
it('creates a line for each ticks excluding the first and last', () => {
expect(ticksG.find('line').length).toBe(defaultProps.numTicks - 1);
setup({ numTicks: 6 });
// defaultProps.numTicks - 1 === expect
expect(screen.getByTestId('ticks').children).toHaveLength(5);
});
});

2
packages/jaeger-ui-components/src/TracePageHeader/SpanGraph/GraphTicks.tsx
View File

@ -42,7 +42,7 @@ export default function GraphTicks(props: GraphTicksProps) {
}
return (
<g data-test="ticks" aria-hidden="true">
<g data-testid="ticks" aria-hidden="true">
{ticks}
</g>
);