IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

QueryEditors: Fixes issue that happens after moving queries then editing would update other queries (#31193)

Browse Source
This commit is contained in:
Torkel Ödegaard 2021-02-15 11:24:03 +01:00 committed by GitHub
parent 5218497a3e
commit 0c3c17592e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/features/query/components/QueryEditorRow.tsx
View File

@ -75,7 +75,7 @@ export class QueryEditorRow extends PureComponent<Props, State> {
} }
getAngularQueryComponentScope(): AngularQueryComponentScope { getAngularQueryComponentScope(): AngularQueryComponentScope {
const { query, onChange, onRunQuery, queries } = this.props; const { query, queries } = this.props;
const { datasource } = this.state; const { datasource } = this.state;
const panel = new PanelModel({ targets: queries }); const panel = new PanelModel({ targets: queries });
const dashboard = {} as DashboardModel; const dashboard = {} as DashboardModel;
@ -87,8 +87,10 @@ export class QueryEditorRow extends PureComponent<Props, State> {
dashboard: dashboard, dashboard: dashboard,
refresh: () => { refresh: () => {
// Old angular editors modify the query model and just call refresh // Old angular editors modify the query model and just call refresh
onChange(query); // Important that this use this.props here so that as this fuction is only created on mount and it's
onRunQuery(); // important not to capture old prop functions in this closure
this.props.onChange(query);
this.props.onRunQuery();
}, },
render: () => () => console.log('legacy render function called, it does nothing'), render: () => () => console.log('legacy render function called, it does nothing'),
events: new EventBusSrv(), events: new EventBusSrv(),