IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

mentioned closes/fixes for new features

Browse Source
This commit is contained in:
bergquist 2019-02-14 09:02:51 +01:00
parent 058debee67
commit 0e6800495f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CONTRIBUTING.md
View File

@ -56,11 +56,13 @@ go test -v ./pkg/...
### New features ### New features
Commits should be as small as possible, while ensuring that each commit is correct independently (i.e., each commit should compile and pass tests). Commits should be as small as possible, while ensuring that each commit is correct independently (i.e., each commit should compile and pass tests).
Make sure to include `closes #<issue>` or `fixes #<issue>` in the pull request description.
### Bug fixes ### Bug fixes
Please make all changes in one commit if possible. Include `closes #12345` in bottom of the commit message. Please make all changes in one commit if possible. Include `closes #12345` in bottom of the commit message.
A commit message for a bugfix should look something like this. A commit message for a bug fix should look something like this.
```git ```
avoid infinite loop in the dashboard provisioner avoid infinite loop in the dashboard provisioner
if one dashboard with an uid is refered to by two if one dashboard with an uid is refered to by two
@ -71,4 +73,4 @@ default settings.
closes #12864 closes #12864
``` ```
If the pull request needs changes before its merged the new commits should be rebased into one commit before its merged.