diff --git a/docs/sources/explore/index.md b/docs/sources/explore/index.md index 59c35daa1ec..982f10e485f 100644 --- a/docs/sources/explore/index.md +++ b/docs/sources/explore/index.md @@ -145,7 +145,7 @@ Suggestions can appear under the query field - click on them to update your quer ### Table filters -Click on the filter button in a labels column in the Table panel to add filters to the query expression. This works with multiple queries too - the filter will be added for all the queries. +Click on the filter button in the "label" column of a Table panel to add filters to the query expression. You can add filters for multiple queries as well - the filter is added for all the queries. ## Logs integration diff --git a/packages/grafana-ui/src/components/Input/Input.tsx b/packages/grafana-ui/src/components/Input/Input.tsx index 8e94f06f5c6..3b01374215e 100644 --- a/packages/grafana-ui/src/components/Input/Input.tsx +++ b/packages/grafana-ui/src/components/Input/Input.tsx @@ -3,7 +3,7 @@ import { GrafanaTheme } from '@grafana/data'; import { css, cx } from 'emotion'; import { getFocusStyle, sharedInputStyle } from '../Forms/commonStyles'; import { stylesFactory, useTheme } from '../../themes'; -import { Icon } from '../Icon/Icon'; +import { Spinner } from '../Spinner/Spinner'; import { useClientRect } from '../../utils/useClientRect'; export interface Props extends Omit, 'prefix' | 'size'> { @@ -249,7 +249,7 @@ export const Input = React.forwardRef((props, ref) => { {(suffix || loading) && (
- {loading && } + {loading && } {suffix}
)} diff --git a/packages/grafana-ui/src/components/LoadingPlaceholder/LoadingPlaceholder.tsx b/packages/grafana-ui/src/components/LoadingPlaceholder/LoadingPlaceholder.tsx index 3194ff3ebb9..4f2db5cd539 100644 --- a/packages/grafana-ui/src/components/LoadingPlaceholder/LoadingPlaceholder.tsx +++ b/packages/grafana-ui/src/components/LoadingPlaceholder/LoadingPlaceholder.tsx @@ -1,5 +1,5 @@ import React, { SFC } from 'react'; -import { Icon } from '../Icon/Icon'; +import { Spinner } from '../Spinner/Spinner'; interface LoadingPlaceholderProps { text: string; @@ -7,6 +7,6 @@ interface LoadingPlaceholderProps { export const LoadingPlaceholder: SFC = ({ text }) => (
- {text} + {text}
); diff --git a/packages/grafana-ui/src/components/Select/SelectBase.tsx b/packages/grafana-ui/src/components/Select/SelectBase.tsx index 5a90fcf31cc..28547cee6ba 100644 --- a/packages/grafana-ui/src/components/Select/SelectBase.tsx +++ b/packages/grafana-ui/src/components/Select/SelectBase.tsx @@ -9,6 +9,7 @@ import { default as ReactAsyncSelect } from '@torkelo/react-select/async'; import { default as AsyncCreatable } from '@torkelo/react-select/async-creatable'; import { Icon } from '../Icon/Icon'; +import { Spinner } from '../Spinner/Spinner'; import { css, cx } from 'emotion'; import resetSelectStyles from './resetSelectStyles'; import { SelectMenu, SelectMenuOptions } from './SelectMenu'; @@ -294,7 +295,7 @@ export function SelectBase({ ); }, LoadingIndicator: (props: any) => { - return ; + return ; }, LoadingMessage: (props: any) => { return
{loadingMessage}
; diff --git a/public/app/core/angular_wrappers.ts b/public/app/core/angular_wrappers.ts index 013634a3abf..2a596be7cc4 100644 --- a/public/app/core/angular_wrappers.ts +++ b/public/app/core/angular_wrappers.ts @@ -14,6 +14,7 @@ import { DataSourceHttpSettings, GraphContextMenu, Icon, + Spinner, LegacyForms, SeriesColorPickerPopoverWithTheme, UnitPicker, @@ -36,12 +37,12 @@ const { SecretFormField } = LegacyForms; export function registerAngularDirectives() { react2AngularDirective('footer', Footer, []); react2AngularDirective('icon', Icon, [ - 'color', 'name', 'size', 'type', ['onClick', { watchDepth: 'reference', wrapApply: true }], ]); + react2AngularDirective('spinner', Spinner, ['inline']); react2AngularDirective('helpModal', HelpModal, []); react2AngularDirective('sidemenu', SideMenu, []); react2AngularDirective('functionEditor', FunctionEditor, ['func', 'onRemove', 'onMoveLeft', 'onMoveRight']); diff --git a/public/app/core/components/PermissionList/PermissionList.tsx b/public/app/core/components/PermissionList/PermissionList.tsx index 772baa0c274..043edc4bd27 100644 --- a/public/app/core/components/PermissionList/PermissionList.tsx +++ b/public/app/core/components/PermissionList/PermissionList.tsx @@ -24,7 +24,6 @@ class PermissionList extends PureComponent { item={{ name: 'Admin', permission: 4, - icon: 'fa fa-fw fa-street-view', }} /> {items.map((item, idx) => { diff --git a/public/app/features/admin/UserSyncInfo.tsx b/public/app/features/admin/UserSyncInfo.tsx index 5d76bf5c120..9e53df0b952 100644 --- a/public/app/features/admin/UserSyncInfo.tsx +++ b/public/app/features/admin/UserSyncInfo.tsx @@ -1,7 +1,7 @@ import React, { PureComponent } from 'react'; import { dateTimeFormat } from '@grafana/data'; import { LdapUserSyncInfo } from 'app/types'; -import { Icon } from '@grafana/ui'; +import { Spinner } from '@grafana/ui'; interface Props { disableSync: boolean; @@ -45,7 +45,7 @@ export class UserSyncInfo extends PureComponent { <>
diff --git a/public/app/features/admin/ldap/LdapSyncInfo.tsx b/public/app/features/admin/ldap/LdapSyncInfo.tsx index 39e256fcceb..aaef28e1288 100644 --- a/public/app/features/admin/ldap/LdapSyncInfo.tsx +++ b/public/app/features/admin/ldap/LdapSyncInfo.tsx @@ -1,6 +1,6 @@ import React, { PureComponent } from 'react'; import { dateTimeFormat } from '@grafana/data'; -import { Icon } from '@grafana/ui'; +import { Spinner } from '@grafana/ui'; import { SyncInfo } from 'app/types'; interface Props { @@ -35,7 +35,7 @@ export class LdapSyncInfo extends PureComponent { LDAP Synchronisation
diff --git a/public/app/features/dashboard/components/DashboardRow/DashboardRow.tsx b/public/app/features/dashboard/components/DashboardRow/DashboardRow.tsx index 1ed2f8254e3..7ec347d7415 100644 --- a/public/app/features/dashboard/components/DashboardRow/DashboardRow.tsx +++ b/public/app/features/dashboard/components/DashboardRow/DashboardRow.tsx @@ -53,7 +53,7 @@ export class DashboardRow extends React.Component { title: 'Delete Row', text: 'Are you sure you want to remove this row and all its panels?', altActionText: 'Delete row only', - icon: 'fa-trash', + icon: 'trash-alt', onConfirm: () => { this.props.dashboard.removeRow(this.props.panel, true); }, diff --git a/public/app/features/dashboard/components/Inspector/InspectDataTab.tsx b/public/app/features/dashboard/components/Inspector/InspectDataTab.tsx index 00278f62362..7156006f499 100644 --- a/public/app/features/dashboard/components/Inspector/InspectDataTab.tsx +++ b/public/app/features/dashboard/components/Inspector/InspectDataTab.tsx @@ -11,7 +11,7 @@ import { toCSV, transformDataFrame, } from '@grafana/data'; -import { Button, Container, Field, HorizontalGroup, Icon, Select, Switch, Table, VerticalGroup } from '@grafana/ui'; +import { Button, Container, Field, HorizontalGroup, Spinner, Select, Switch, Table, VerticalGroup } from '@grafana/ui'; import { CSVConfig } from '@grafana/data'; import { selectors } from '@grafana/e2e-selectors'; @@ -261,7 +261,7 @@ export class InspectDataTab extends PureComponent { if (isLoading) { return (
- Loading + Loading
); } diff --git a/public/app/features/dashboard/components/ShareModal/ShareSnapshot.tsx b/public/app/features/dashboard/components/ShareModal/ShareSnapshot.tsx index 282d0d3635e..d9a67e30b67 100644 --- a/public/app/features/dashboard/components/ShareModal/ShareSnapshot.tsx +++ b/public/app/features/dashboard/components/ShareModal/ShareSnapshot.tsx @@ -1,5 +1,5 @@ import React, { PureComponent } from 'react'; -import { Button, ClipboardButton, Icon, LegacyForms, LinkButton } from '@grafana/ui'; +import { Button, ClipboardButton, Icon, Spinner, LegacyForms, LinkButton } from '@grafana/ui'; import { AppEvents, SelectableValue } from '@grafana/data'; import { getBackendSrv } from '@grafana/runtime'; import { DashboardModel, PanelModel } from 'app/features/dashboard/state'; @@ -306,7 +306,7 @@ export class ShareSnapshot extends PureComponent {
{isLoading ? (
- +
) : ( diff --git a/public/app/features/dashboard/components/VersionHistory/HistoryListCtrl.ts b/public/app/features/dashboard/components/VersionHistory/HistoryListCtrl.ts index e9b461f4edd..c459734014f 100644 --- a/public/app/features/dashboard/components/VersionHistory/HistoryListCtrl.ts +++ b/public/app/features/dashboard/components/VersionHistory/HistoryListCtrl.ts @@ -176,7 +176,7 @@ export class HistoryListCtrl { title: 'Restore version', text: '', text2: `Are you sure you want to restore the dashboard to version ${version}? All unsaved changes will be lost.`, - icon: 'fa-history', + icon: 'history', yesText: `Yes, restore to version ${version}`, onConfirm: this.restoreConfirm.bind(this, version), }); diff --git a/public/app/features/dashboard/components/VersionHistory/template.html b/public/app/features/dashboard/components/VersionHistory/template.html index 768367787ef..ac42c42c890 100644 --- a/public/app/features/dashboard/components/VersionHistory/template.html +++ b/public/app/features/dashboard/components/VersionHistory/template.html @@ -10,7 +10,8 @@
- + + Fetching history list…
@@ -63,7 +64,8 @@
- + + Fetching more entries…
@@ -97,7 +99,8 @@
- + + Fetching changes…
diff --git a/public/app/features/dashboard/containers/DashboardPage.tsx b/public/app/features/dashboard/containers/DashboardPage.tsx index f7bd7a0c62f..726a4761354 100644 --- a/public/app/features/dashboard/containers/DashboardPage.tsx +++ b/public/app/features/dashboard/containers/DashboardPage.tsx @@ -13,7 +13,7 @@ import { DashboardGrid } from '../dashgrid/DashboardGrid'; import { DashNav } from '../components/DashNav'; import { DashboardSettings } from '../components/DashboardSettings'; import { PanelEditor } from '../components/PanelEditor/PanelEditor'; -import { Alert, Button, CustomScrollbar, HorizontalGroup, Icon, VerticalGroup } from '@grafana/ui'; +import { Alert, Button, CustomScrollbar, HorizontalGroup, Spinner, VerticalGroup } from '@grafana/ui'; // Redux import { initDashboard } from '../state/initDashboard'; import { notifyApp, updateLocation } from 'app/core/actions'; @@ -235,7 +235,7 @@ export class DashboardPage extends PureComponent {
- {this.props.initPhase} + {this.props.initPhase} {' '} ); diff --git a/public/app/features/variables/pickers/shared/VariableOptions.tsx b/public/app/features/variables/pickers/shared/VariableOptions.tsx index 4c601148b13..3171ab5d1a5 100644 --- a/public/app/features/variables/pickers/shared/VariableOptions.tsx +++ b/public/app/features/variables/pickers/shared/VariableOptions.tsx @@ -78,7 +78,7 @@ export class VariableOptions extends PureComponent { className={`${tag.selected ? 'variable-option-tag pointer selected' : 'variable-option-tag pointer'}`} onClick={this.onToggleTag(tag)} > - + {tag.text}   diff --git a/public/app/plugins/datasource/cloudwatch/components/CloudWatchLink.tsx b/public/app/plugins/datasource/cloudwatch/components/CloudWatchLink.tsx index 20afa8f0ac5..768e7c806cb 100644 --- a/public/app/plugins/datasource/cloudwatch/components/CloudWatchLink.tsx +++ b/public/app/plugins/datasource/cloudwatch/components/CloudWatchLink.tsx @@ -3,6 +3,7 @@ import React, { Component } from 'react'; import { CloudWatchLogsQuery } from '../types'; import { PanelData } from '@grafana/data'; +import { Icon } from '@grafana/ui'; import { encodeUrl, AwsUrl } from '../aws_url'; import { CloudWatchDatasource } from '../datasource'; @@ -58,7 +59,7 @@ export default class CloudWatchLink extends Component { const { href } = this.state; return ( - CloudWatch Logs Insights + CloudWatch Logs Insights ); } diff --git a/public/app/plugins/panel/annolist/AnnoListPanel.tsx b/public/app/plugins/panel/annolist/AnnoListPanel.tsx index 63342c6b4aa..631b4295610 100644 --- a/public/app/plugins/panel/annolist/AnnoListPanel.tsx +++ b/public/app/plugins/panel/annolist/AnnoListPanel.tsx @@ -266,7 +266,7 @@ export class AnnoListPanel extends PureComponent { // Previously we showed inidication that it covered all time // { timeInfo && ( // - // {timeInfo} + // {timeInfo} // // )} diff --git a/public/test/mocks/common.ts b/public/test/mocks/common.ts index a660ea11b08..9eee9d09d3e 100644 --- a/public/test/mocks/common.ts +++ b/public/test/mocks/common.ts @@ -24,7 +24,7 @@ export function createNavModel(title: string, ...tabs: string[]): NavModel { const node: NavModelItem = { id: title, text: title, - icon: 'fa fa-fw fa-warning', + icon: 'exclamation-triangle', subTitle: 'subTitle', url: title, children: [],