From 107f658229efc3800571f9b92e1ca4d108e81b85 Mon Sep 17 00:00:00 2001 From: Arve Knudsen Date: Fri, 27 Nov 2020 12:05:49 +0100 Subject: [PATCH] prometheus: Improve IsAPIError's documentation (#29432) Signed-off-by: Arve Knudsen --- pkg/tsdb/prometheus/prometheus.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/tsdb/prometheus/prometheus.go b/pkg/tsdb/prometheus/prometheus.go index a8efe60b179..1eb1da6e8cf 100644 --- a/pkg/tsdb/prometheus/prometheus.go +++ b/pkg/tsdb/prometheus/prometheus.go @@ -218,9 +218,9 @@ func parseResponse(value model.Value, query *PrometheusQuery) (*tsdb.QueryResult return queryRes, nil } +// IsAPIError returns whether err is or wraps a Prometheus error. func IsAPIError(err error) bool { - // Have to use errors.As to compare Prometheus errors, since errors.Is won't work due to Prometheus - // errors being pointers and errors.Is ends up comparing them by pointer address + // Check if the right error type is in err's chain. var e *apiv1.Error return errors.As(err, &e) }