IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-01-28 17:24:59 -06:00
Code Issues Packages Projects Releases Wiki Activity

enable rule role-has-required-aria-props (#55841)

Browse Source
This commit is contained in:
Ashley Harrison 2022-09-27 16:17:26 +01:00 committed by GitHub
parent edcf359473
commit 11eb02a183
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.betterer.results
View File

@ -5962,26 +5962,6 @@ exports[`better eslint`] = {
[0, 0, 0, "Do not use any type assertions.", "0"], [0, 0, 0, "Do not use any type assertions.", "0"],
[0, 0, 0, "Do not use any type assertions.", "1"] [0, 0, 0, "Do not use any type assertions.", "1"]
], ],
"public/app/plugins/datasource/elasticsearch/ElasticResponse.test.ts:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"],
[0, 0, 0, "Unexpected any. Specify a different type.", "1"],
[0, 0, 0, "Unexpected any. Specify a different type.", "2"],
[0, 0, 0, "Unexpected any. Specify a different type.", "3"],
[0, 0, 0, "Unexpected any. Specify a different type.", "4"],
[0, 0, 0, "Unexpected any. Specify a different type.", "5"],
[0, 0, 0, "Unexpected any. Specify a different type.", "6"],
[0, 0, 0, "Unexpected any. Specify a different type.", "7"],
[0, 0, 0, "Unexpected any. Specify a different type.", "8"],
[0, 0, 0, "Unexpected any. Specify a different type.", "9"],
[0, 0, 0, "Unexpected any. Specify a different type.", "10"],
[0, 0, 0, "Unexpected any. Specify a different type.", "11"],
[0, 0, 0, "Unexpected any. Specify a different type.", "12"],
[0, 0, 0, "Unexpected any. Specify a different type.", "13"],
[0, 0, 0, "Unexpected any. Specify a different type.", "14"],
[0, 0, 0, "Unexpected any. Specify a different type.", "15"],
[0, 0, 0, "Unexpected any. Specify a different type.", "16"],
[0, 0, 0, "Unexpected any. Specify a different type.", "17"]
],
"public/app/plugins/datasource/elasticsearch/ElasticResponse.ts:5381": [ "public/app/plugins/datasource/elasticsearch/ElasticResponse.ts:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"], [0, 0, 0, "Unexpected any. Specify a different type.", "0"],
[0, 0, 0, "Unexpected any. Specify a different type.", "1"], [0, 0, 0, "Unexpected any. Specify a different type.", "1"],

2
.eslintrc
View File

@ -90,7 +90,7 @@
"jsx-a11y/no-noninteractive-tabindex": "off", "jsx-a11y/no-noninteractive-tabindex": "off",
"jsx-a11y/no-redundant-roles": "error", "jsx-a11y/no-redundant-roles": "error",
"jsx-a11y/no-static-element-interactions": "off", "jsx-a11y/no-static-element-interactions": "off",
"jsx-a11y/role-has-required-aria-props": "off", "jsx-a11y/role-has-required-aria-props": "error",
"jsx-a11y/role-supports-aria-props": "error", "jsx-a11y/role-supports-aria-props": "error",
"jsx-a11y/scope": "error", "jsx-a11y/scope": "error",
"jsx-a11y/tabindex-no-positive": "error" "jsx-a11y/tabindex-no-positive": "error"

2
packages/grafana-ui/src/components/FormField/FormField.test.tsx
View File

@ -24,7 +24,7 @@ describe('FormField', () => {
it('should render a custom inputEl instead if specified', () => { it('should render a custom inputEl instead if specified', () => {
setup({ setup({
inputEl: <input role="checkbox" />, inputEl: <input type="checkbox" />,
}); });
expect(screen.queryByRole('textbox')).not.toBeInTheDocument(); expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
expect(screen.getByRole('checkbox')).toBeInTheDocument(); expect(screen.getByRole('checkbox')).toBeInTheDocument();

2
public/app/features/scenes/components/NestedScene.tsx
View File

@ -62,7 +62,7 @@ export function NestedSceneRenderer({ model, isEditing }: SceneComponentProps<Ne
<div className={styles.row}> <div className={styles.row}>
<div className={styles.rowHeader}> <div className={styles.rowHeader}>
<Stack gap={0}> <Stack gap={0}>
<div className={styles.title} role="heading"> <div className={styles.title} role="heading" aria-level={1}>
{title} {title}
</div> </div>
{canCollapse && ( {canCollapse && (