IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: Clean up per PR feedback. Thanks @dprokop

Browse Source
This commit is contained in:
Johannes Schill 2019-01-08 16:04:46 +01:00
parent f428db282c
commit 12a3edd6e5
2 changed files with 10 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
public/app/core/components/ErrorBoundary/ErrorBoundary.tsx
View File

@ -1,4 +1,4 @@
import React, { Component } from 'react'; import { Component } from 'react';
interface ErrorInfo { interface ErrorInfo {
componentStack: string; componentStack: string;
@ -19,10 +19,10 @@ interface State {
} }
class ErrorBoundary extends Component<Props, State> { class ErrorBoundary extends Component<Props, State> {
constructor(props) { readonly state: State = {
super(props); error: null,
this.state = { error: null, errorInfo: null }; errorInfo: null,
} };
componentDidCatch(error: Error, errorInfo: ErrorInfo) { componentDidCatch(error: Error, errorInfo: ErrorInfo) {
this.setState({ this.setState({
@ -32,15 +32,12 @@ class ErrorBoundary extends Component<Props, State> {
} }
render() { render() {
const { children } = this.props;
const { error, errorInfo } = this.state; const { error, errorInfo } = this.state;
return ( return children({
<>
{this.props.children({
error, error,
errorInfo, errorInfo,
})} });
</>
);
} }
} }

4
public/app/plugins/panel/graph2/GraphPanel.tsx
View File

@ -10,10 +10,6 @@ import { Options } from './types';
interface Props extends PanelProps<Options> {} interface Props extends PanelProps<Options> {}
export class GraphPanel extends PureComponent<Props> { export class GraphPanel extends PureComponent<Props> {
constructor(props: Props) {
super(props);
}
render() { render() {
const { timeSeries, timeRange, width, height } = this.props; const { timeSeries, timeRange, width, height } = this.props;
const { showLines, showBars, showPoints } = this.props.options; const { showLines, showBars, showPoints } = this.props.options;