IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

UI/Switch: Makes Switch ID generation more stable (#25542)

Browse Source
This commit is contained in:
kay delaney 2020-06-11 12:47:49 +01:00 committed by GitHub
parent 79fea5df2a
commit 12d2f2c026
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grafana-ui/src/components/Switch/Switch.tsx
View File

@ -1,4 +1,4 @@
import React, { HTMLProps } from 'react';
import React, { HTMLProps, useRef } from 'react';
import { css, cx } from 'emotion';
import uniqueId from 'lodash/uniqueId';
import { GrafanaTheme } from '@grafana/data';
@ -79,7 +79,7 @@ export const Switch = React.forwardRef<HTMLInputElement, SwitchProps>(
({ value, checked, disabled = false, onChange, ...inputProps }, ref) => {
const theme = useTheme();
const styles = getSwitchStyles(theme);
const switchId = uniqueId('switch-');
const switchIdRef = useRef(uniqueId('switch-'));
return (
<div className={cx(styles.switch)}>
@ -90,11 +90,11 @@ export const Switch = React.forwardRef<HTMLInputElement, SwitchProps>(
onChange={event => {
onChange?.(event);
}}
id={switchId}
id={switchIdRef.current}
{...inputProps}
ref={ref}
/>
<label htmlFor={switchId} />
<label htmlFor={switchIdRef.current} />
</div>
);
}