From 148e1c1588e9f075b14b72eb87d5463ea5bbb253 Mon Sep 17 00:00:00 2001 From: Virginia Cepeda Date: Thu, 30 Nov 2023 15:28:37 -0300 Subject: [PATCH] Alerting: Change create/update permissions for silences (#78920) * Change create/update permissions for silences * Add comment --- .../unified/hooks/__snapshots__/useAbilities.test.tsx.snap | 4 ++-- public/app/features/alerting/unified/hooks/useAbilities.ts | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/public/app/features/alerting/unified/hooks/__snapshots__/useAbilities.test.tsx.snap b/public/app/features/alerting/unified/hooks/__snapshots__/useAbilities.test.tsx.snap index 6b710d02d41..8308f80f498 100644 --- a/public/app/features/alerting/unified/hooks/__snapshots__/useAbilities.test.tsx.snap +++ b/public/app/features/alerting/unified/hooks/__snapshots__/useAbilities.test.tsx.snap @@ -19,7 +19,7 @@ exports[`alertmanager abilities should report Create / Update / Delete actions a false, ], "create-silence": [ - false, + true, false, ], "decrypt-secrets": [ @@ -71,7 +71,7 @@ exports[`alertmanager abilities should report Create / Update / Delete actions a false, ], "update-silence": [ - false, + true, false, ], "view-contact-point": [ diff --git a/public/app/features/alerting/unified/hooks/useAbilities.ts b/public/app/features/alerting/unified/hooks/useAbilities.ts index 71686ea07e6..892778a8df5 100644 --- a/public/app/features/alerting/unified/hooks/useAbilities.ts +++ b/public/app/features/alerting/unified/hooks/useAbilities.ts @@ -226,9 +226,10 @@ export function useAllAlertmanagerAbilities(): Abilities { notificationsPermissions.provisioning.readSecrets ), // -- silences -- - [AlertmanagerAction.CreateSilence]: toAbility(hasConfigurationAPI, instancePermissions.create), + // for now, all supported Alertmanager flavors have API endpoints for managing silences + [AlertmanagerAction.CreateSilence]: toAbility(AlwaysSupported, instancePermissions.create), [AlertmanagerAction.ViewSilence]: toAbility(AlwaysSupported, instancePermissions.read), - [AlertmanagerAction.UpdateSilence]: toAbility(hasConfigurationAPI, instancePermissions.update), + [AlertmanagerAction.UpdateSilence]: toAbility(AlwaysSupported, instancePermissions.update), // -- mute timtings -- [AlertmanagerAction.CreateMuteTiming]: toAbility(hasConfigurationAPI, notificationsPermissions.create), [AlertmanagerAction.ViewMuteTiming]: toAbility(AlwaysSupported, notificationsPermissions.read),