Chore: Enable strict Typescript checks (#41198)

* Chore: Enable strict Typescript checking

* Chore: Remove old strict budget checks

.drone.yml

@@ -68,7 +68,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -340,7 +339,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -793,7 +791,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -1171,7 +1168,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -1727,7 +1723,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -2094,7 +2089,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -2647,7 +2641,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -2986,7 +2979,6 @@ steps:
   - yarn run prettier:check
   - yarn run lint
   - yarn run typecheck
-  - yarn run check-strict
   depends_on:
   - initialize
   environment:
@@ -3449,6 +3441,6 @@ kind: secret
 name: drone_token
 ---
 kind: signature
-hmac: 0fc151dbfb52c9055ebe8b2c8393d351bed186b1c52a1ca61e67a58c1e7fce52
+hmac: 746a9f310520cd57b0a464b91049565aa99138fbec92568cadd99d51871e8e56
 
 ...

package.json

@@ -8,7 +8,6 @@
   "scripts": {
     "api-tests": "jest --notify --watch --config=devenv/e2e-api-tests/jest.js",
     "build": "webpack --config scripts/webpack/webpack.prod.js",
-    "check-strict": "./scripts/ci-check-strict.sh",
     "dev": "webpack --progress --color --config scripts/webpack/webpack.dev.js",
     "e2e": "./e2e/start-and-run-suite",
     "e2e:debug": "./e2e/start-and-run-suite debug",

scripts/ci-check-strict.sh

@@ -1,13 +0,0 @@
-#!/bin/bash
-set -e
-
-echo -e "Collecting code stats (typescript errors & more)"
-
-ERROR_COUNT_LIMIT=1
-ERROR_COUNT="$(yarn run tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')"
-
-if [ "$ERROR_COUNT" -gt $ERROR_COUNT_LIMIT ]; then
-  echo -e "Typescript strict errors $ERROR_COUNT exceeded $ERROR_COUNT_LIMIT so failing build"
-	exit 1
-fi
-

scripts/drone/steps/lib.star

@@ -421,7 +421,6 @@ def lint_frontend_step():
             'yarn run prettier:check',
             'yarn run lint',
             'yarn run typecheck',
-            'yarn run check-strict',
         ],
     }
 

tsconfig.json

@@ -5,7 +5,7 @@
     "outDir": "public/dist",
     "rootDirs": ["public/"],
     "allowJs": true,
-    "strictNullChecks": true,
+    "strict": true,
     "resolveJsonModule": true,
     "useUnknownInCatchVariables": false
   },