Toolkit: fix prettier error reporting (#21599)

This commit is contained in:
Ryan McKinley 2020-01-19 18:42:41 -08:00 committed by GitHub
parent d2b08c8368
commit 152059fec9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -87,22 +87,23 @@ export const prettierCheckPlugin = useSpinner<Fixable>('Prettier check', async (
} }
}) })
.then(newContents => { .then(newContents => {
if (fix && newContents && newContents.length > 10) { if (newContents === undefined) {
return writeFile(path, newContents) return true; // Nothing to fix
.then(() => {
console.log(`Fixed: ${path}`);
return true;
})
.catch(error => {
console.log(`Error fixing ${path}`, error);
return false;
});
} else if (fix) { } else if (fix) {
if (newContents.length > 10) {
return writeFile(path, newContents)
.then(() => {
console.log(`Fixed: ${path}`);
return true;
})
.catch(error => {
console.log(`Error fixing ${path}`, error);
return false;
});
}
console.log(`No automatic fix for: ${path}`); console.log(`No automatic fix for: ${path}`);
return false;
} else {
return false;
} }
return false;
}) })
.then(success => ({ path, success })) .then(success => ({ path, success }))
); );