Chore: Fix broken pa11y-ci (#41597)

* Chore: Fix broken pa11y-ci

* Chore: using npx instead

* Chore: testing with prebuilt image

* Chore: testing bin path

* Chore: trying

* Chore: another try

* Update puppeteer image

* Chore: updating image

* Chore: removes yarn version printout

* Chore: removes yarn version printout

Co-authored-by: dsotirakis <sotirakis.dim@gmail.com>
This commit is contained in:
Hugo Häggmark 2021-11-15 08:49:39 +01:00 committed by GitHub
parent a50b6947ce
commit 16578b0af0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 11 deletions

View File

@ -212,8 +212,7 @@ steps:
name: build-storybook name: build-storybook
- commands: - commands:
- yarn wait-on http://$HOST:$PORT - yarn wait-on http://$HOST:$PORT
- yarn dlx pa11y-ci@git://github.com/pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 - pa11y-ci --config .pa11yci-pr.conf.js
pa11y-ci --config .pa11yci-pr.conf.js
depends_on: depends_on:
- end-to-end-tests-server - end-to-end-tests-server
environment: environment:
@ -222,7 +221,7 @@ steps:
HOST: end-to-end-tests-server HOST: end-to-end-tests-server
PORT: 3001 PORT: 3001
failure: ignore failure: ignore
image: buildkite/puppeteer image: hugohaggmark/docker-puppeteer
name: test-a11y-frontend name: test-a11y-frontend
- commands: - commands:
- ./scripts/ci-reference-docs-lint.sh ci - ./scripts/ci-reference-docs-lint.sh ci
@ -507,8 +506,7 @@ steps:
name: publish-storybook name: publish-storybook
- commands: - commands:
- yarn wait-on http://$HOST:$PORT - yarn wait-on http://$HOST:$PORT
- yarn dlx --quiet pa11y-ci@git://github.com/pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 - pa11y-ci --config .pa11yci.conf.js --json > pa11y-ci-results.json
pa11y-ci --config .pa11yci.conf.js --json > pa11y-ci-results.json
depends_on: depends_on:
- end-to-end-tests-server - end-to-end-tests-server
environment: environment:
@ -517,7 +515,7 @@ steps:
HOST: end-to-end-tests-server HOST: end-to-end-tests-server
PORT: 3001 PORT: 3001
failure: ignore failure: ignore
image: buildkite/puppeteer image: hugohaggmark/docker-puppeteer
name: test-a11y-frontend name: test-a11y-frontend
- commands: - commands:
- ./scripts/ci-frontend-metrics.sh | ./bin/grabpl publish-metrics $${GRAFANA_MISC_STATS_API_KEY} - ./scripts/ci-frontend-metrics.sh | ./bin/grabpl publish-metrics $${GRAFANA_MISC_STATS_API_KEY}
@ -3432,6 +3430,6 @@ kind: secret
name: drone_token name: drone_token
--- ---
kind: signature kind: signature
hmac: 612011aafafad61d355de61b10daaffd947817161667385a216cb82d8c2a7b1d hmac: d2db1d71a52922f66df9d327cb8991944d6fd050b4ad4d36e5f7cfb9f79f9297
... ...

View File

@ -428,16 +428,16 @@ def test_a11y_frontend_step(ver_mode, edition, port=3001):
] ]
if ver_mode == 'pr': if ver_mode == 'pr':
commands.extend([ commands.extend([
'yarn dlx pa11y-ci@git://github.com/pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 pa11y-ci --config .pa11yci-pr.conf.js', 'pa11y-ci --config .pa11yci-pr.conf.js',
]) ])
else: else:
commands.extend([ commands.extend([
'yarn dlx --quiet pa11y-ci@git://github.com/pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 pa11y-ci --config .pa11yci.conf.js --json > pa11y-ci-results.json', 'pa11y-ci --config .pa11yci.conf.js --json > pa11y-ci-results.json',
]) ])
return { return {
'name': 'test-a11y-frontend' + enterprise2_suffix(edition), 'name': 'test-a11y-frontend' + enterprise2_suffix(edition),
'image': 'buildkite/puppeteer', 'image': 'hugohaggmark/docker-puppeteer',
'depends_on': [ 'depends_on': [
'end-to-end-tests-server' + enterprise2_suffix(edition), 'end-to-end-tests-server' + enterprise2_suffix(edition),
], ],

View File

@ -27,7 +27,7 @@ else
fi fi
# Run accessibility command # Run accessibility command
yarn dlx --quiet pa11y-ci@git://github.com/pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 --config .pa11yci.conf.js --json > pa11y-ci-results.json yarn dlx --quiet pa11y-ci@pa11y/pa11y-ci#5c842cf1b9fe2867b70ff5354851d985be8d71c4 --config .pa11yci.conf.js --json > pa11y-ci-results.json
# Generate HTML report # Generate HTML report
yarn dlx pa11y-ci-reporter-html@3.0.1 pa11y-ci-reporter-html yarn dlx pa11y-ci-reporter-html@3.0.1 pa11y-ci-reporter-html