stackdriver: use standard naming convention for selects

This commit is contained in:
Erik Sundell 2018-10-30 09:43:08 +01:00
parent d80025d215
commit 16c6d79dd6
3 changed files with 11 additions and 11 deletions

View File

@ -7,7 +7,7 @@ interface Props {
metricDescriptors: any[];
}
const MetricTypeSelector: SFC<Props> = props => {
const MetricTypePicker: SFC<Props> = props => {
const filterMetricTypes = () => {
if (!props.selectedService) {
return [];
@ -35,4 +35,4 @@ const MetricTypeSelector: SFC<Props> = props => {
);
};
export default MetricTypeSelector;
export default MetricTypePicker;

View File

@ -6,7 +6,7 @@ interface Props {
metricDescriptors: any[];
}
const ServiceSelector: SFC<Props> = props => {
const ServicePicker: SFC<Props> = props => {
const extractServices = () => {
return extractServicesFromMetricDescriptors(props.metricDescriptors).map(m => ({
value: m.service,
@ -30,4 +30,4 @@ const ServiceSelector: SFC<Props> = props => {
);
};
export default ServiceSelector;
export default ServicePicker;

View File

@ -1,6 +1,6 @@
import React, { PureComponent } from 'react';
import ServiceSelector from './ServiceSelector';
import MetricTypeSelector from './MetricTypeSelector';
import ServicePicker from './ServicePicker';
import MetricTypePicker from './MetricTypePicker';
import SimpleDropdown from './SimpleDropdown';
import { TemplateQueryProps } from 'app/types/plugins';
import defaultsDeep from 'lodash/defaultsDeep';
@ -113,7 +113,7 @@ export class StackdriverTemplateQueryComponent extends PureComponent<TemplateQue
switch (queryType) {
case MetricFindQueryTypes.MetricTypes:
return (
<ServiceSelector metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
<ServicePicker metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
);
case MetricFindQueryTypes.MetricLabels:
case MetricFindQueryTypes.ResourceLabels:
@ -121,8 +121,8 @@ export class StackdriverTemplateQueryComponent extends PureComponent<TemplateQue
const dropdown = this.getDropdown(queryType);
return (
<React.Fragment>
<ServiceSelector metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
<MetricTypeSelector
<ServicePicker metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
<MetricTypePicker
selectedService={this.state.service}
metricDescriptors={this.state.metricDescriptors}
onMetricTypeChange={this.onMetricTypeChange}
@ -134,8 +134,8 @@ export class StackdriverTemplateQueryComponent extends PureComponent<TemplateQue
case MetricFindQueryTypes.Aggregations:
return (
<React.Fragment>
<ServiceSelector metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
<MetricTypeSelector
<ServicePicker metricDescriptors={this.state.metricDescriptors} onServiceChange={this.onServiceChange} />
<MetricTypePicker
selectedService={this.state.service}
metricDescriptors={this.state.metricDescriptors}
onMetricTypeChange={this.onMetricTypeChange}