From 174c2ab45a2af912519153c5c3e671f04396d7d7 Mon Sep 17 00:00:00 2001 From: Matias Chomicki Date: Thu, 9 Nov 2023 11:54:03 +0100 Subject: [PATCH] Logs infinite scrolling: create feature flag (#77885) logsInfiniteScrolling: create feature flag --- .../configure-grafana/feature-toggles/index.md | 1 + packages/grafana-data/src/types/featureToggles.gen.ts | 1 + pkg/services/featuremgmt/registry.go | 7 +++++++ pkg/services/featuremgmt/toggles_gen.csv | 1 + pkg/services/featuremgmt/toggles_gen.go | 4 ++++ 5 files changed, 14 insertions(+) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 3ad792e1f73..5156b41c083 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -162,6 +162,7 @@ Experimental features might be changed or removed without prior notice. | `annotationPermissionUpdate` | Separate annotation permissions from dashboard permissions to allow for more granular control. | | `extractFieldsNameDeduplication` | Make sure extracted field names are unique in the dataframe | | `dashboardSceneForViewers` | Enables dashboard rendering using Scenes for viewer roles | +| `logsInfiniteScrolling` | Enables infinite scrolling for the Logs panel in Explore and Dashboards | ## Development feature toggles diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index 2c377fe3d16..00a62a48503 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -159,4 +159,5 @@ export interface FeatureToggles { panelFilterVariable?: boolean; pdfTables?: boolean; ssoSettingsApi?: boolean; + logsInfiniteScrolling?: boolean; } diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 622c6d8d125..fcd8f29573e 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1025,6 +1025,13 @@ var ( FrontendOnly: false, Owner: identityAccessTeam, }, + { + Name: "logsInfiniteScrolling", + Description: "Enables infinite scrolling for the Logs panel in Explore and Dashboards", + Stage: FeatureStageExperimental, + FrontendOnly: true, + Owner: grafanaObservabilityLogsSquad, + }, } ) diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index fda0776cfaa..e4aa8f67318 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -140,3 +140,4 @@ dashboardSceneForViewers,experimental,@grafana/dashboards-squad,false,false,fals panelFilterVariable,experimental,@grafana/dashboards-squad,false,false,false,true pdfTables,privatePreview,@grafana/sharing-squad,false,false,false,false ssoSettingsApi,experimental,@grafana/identity-access-team,true,false,false,false +logsInfiniteScrolling,experimental,@grafana/observability-logs,false,false,false,true diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 4a9b85e3f49..121b5f50b27 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -570,4 +570,8 @@ const ( // FlagSsoSettingsApi // Enables the SSO settings API FlagSsoSettingsApi = "ssoSettingsApi" + + // FlagLogsInfiniteScrolling + // Enables infinite scrolling for the Logs panel in Explore and Dashboards + FlagLogsInfiniteScrolling = "logsInfiniteScrolling" )