IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: support empty/missing strings (#34027)

Browse Source
This commit is contained in:
Ryan McKinley 2021-05-12 16:51:20 -07:00 committed by GitHub
parent 7bcb938b80
commit 17750d3cdb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/grafana-data/src/field/displayProcessor.test.ts
View File

@ -346,6 +346,11 @@ describe('Date display options', () => {
theme: createTheme(), theme: createTheme(),
}); });
expect(processor('22.1122334455').text).toEqual('22.11'); expect(processor('22.1122334455').text).toEqual('22.11');
// Support empty/missing strings
expect(processor(undefined).text).toEqual('');
expect(processor(null).text).toEqual('');
expect(processor('').text).toEqual('');
}); });
}); });
}); });

4
packages/grafana-data/src/field/displayProcessor.ts
View File

@ -137,6 +137,10 @@ export function getRawDisplayProcessor(): DisplayProcessor {
function getDefaultColorFunc(field: Field, scaleFunc: ScaleCalculator, theme: GrafanaTheme2) { function getDefaultColorFunc(field: Field, scaleFunc: ScaleCalculator, theme: GrafanaTheme2) {
if (field.type === FieldType.string) { if (field.type === FieldType.string) {
return (value: any) => { return (value: any) => {
if (!value) {
return { color: theme.colors.background.primary, percent: 0 };
}
const hc = strHashCode(value as string); const hc = strHashCode(value as string);
return { return {
color: classicColors[Math.floor(hc % classicColors.length)], color: classicColors[Math.floor(hc % classicColors.length)],