IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Removes console output LogDetails.test.tsx and refactors to RTL (#45193)

Browse Source
This commit is contained in:
Hugo Häggmark 2022-02-10 11:06:29 +01:00 committed by GitHub
parent 5edcc2e795
commit 192572174e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.betterer.results
View File

@ -44,9 +44,6 @@ exports[`no enzyme tests`] = {
"packages/grafana-ui/src/components/List/AbstractList.test.tsx:2210654375": [ "packages/grafana-ui/src/components/List/AbstractList.test.tsx:2210654375": [
[1, 19, 13, "RegExp match", "2409514259"] [1, 19, 13, "RegExp match", "2409514259"]
], ],
"packages/grafana-ui/src/components/Logs/LogDetails.test.tsx:1917110956": [
[3, 17, 13, "RegExp match", "2409514259"]
],
"packages/grafana-ui/src/components/Logs/LogLabels.test.tsx:1113070745": [ "packages/grafana-ui/src/components/Logs/LogLabels.test.tsx:1113070745": [
[1, 19, 13, "RegExp match", "2409514259"] [1, 19, 13, "RegExp match", "2409514259"]
], ],

83
packages/grafana-ui/src/components/Logs/LogDetails.test.tsx
View File

@ -1,8 +1,9 @@
import React from 'react'; import React from 'react';
import { render, screen, within } from '@testing-library/react';
import { Field, GrafanaTheme2, LogLevel, LogRowModel, MutableDataFrame } from '@grafana/data';
import { LogDetails, Props } from './LogDetails'; import { LogDetails, Props } from './LogDetails';
import { LogRowModel, LogLevel, MutableDataFrame, Field, GrafanaTheme2 } from '@grafana/data'; import { expect } from '../../../../../public/test/lib/common';
import { mount } from 'enzyme';
import { LogDetailsRow } from './LogDetailsRow';
const setup = (propOverrides?: Partial<Props>, rowOverrides?: Partial<LogRowModel>) => { const setup = (propOverrides?: Partial<Props>, rowOverrides?: Partial<LogRowModel>) => {
const props: Props = { const props: Props = {
@ -33,60 +34,70 @@ const setup = (propOverrides?: Partial<Props>, rowOverrides?: Partial<LogRowMode
...(propOverrides || {}), ...(propOverrides || {}),
}; };
return mount(<LogDetails {...props} />); render(
<table>
<tbody>
<LogDetails {...props} />
</tbody>
</table>
);
}; };
describe('LogDetails', () => { describe('LogDetails', () => {
describe('when labels are present', () => { describe('when labels are present', () => {
it('should render heading', () => { it('should render heading', () => {
const wrapper = setup(undefined, { labels: { key1: 'label1', key2: 'label2' } }); setup(undefined, { labels: { key1: 'label1', key2: 'label2' } });
expect(wrapper.find({ 'aria-label': 'Log labels' }).hostNodes()).toHaveLength(1); expect(screen.getAllByLabelText('Log labels')).toHaveLength(1);
}); });
it('should render labels', () => { it('should render labels', () => {
const wrapper = setup(undefined, { labels: { key1: 'label1', key2: 'label2' } }); setup(undefined, { labels: { key1: 'label1', key2: 'label2' } });
expect(wrapper.text().includes('key1label1key2label2')).toBe(true); expect(screen.getByRole('cell', { name: 'key1' })).toBeInTheDocument();
expect(screen.getByRole('cell', { name: 'label1' })).toBeInTheDocument();
expect(screen.getByRole('cell', { name: 'key2' })).toBeInTheDocument();
expect(screen.getByRole('cell', { name: 'label2' })).toBeInTheDocument();
}); });
}); });
describe('when log row has error', () => { describe('when log row has error', () => {
it('should not render log level border', () => { it('should not render log level border', () => {
const wrapper = setup({ hasError: true }, undefined); // Is this a good test case for RTL??
expect(wrapper.find({ 'aria-label': 'Log level' }).html()).not.toContain('logs-row__level'); setup({ hasError: true }, undefined);
expect(screen.getByLabelText('Log level').classList.toString()).not.toContain('logs-row__level');
}); });
}); });
describe('when row entry has parsable fields', () => { describe('when row entry has parsable fields', () => {
it('should render heading ', () => { it('should render heading ', () => {
const wrapper = setup(undefined, { entry: 'test=successful' }); setup(undefined, { entry: 'test=successful' });
expect(wrapper.find({ title: 'Ad-hoc statistics' }).hostNodes()).toHaveLength(1); expect(screen.getAllByTitle('Ad-hoc statistics')).toHaveLength(1);
}); });
it('should render detected fields', () => { it('should render detected fields', () => {
const wrapper = setup(undefined, { entry: 'test=successful' }); setup(undefined, { entry: 'test=successful' });
expect(wrapper.text().includes('testsuccessful')).toBe(true); expect(screen.getByRole('cell', { name: 'test' })).toBeInTheDocument();
expect(screen.getByRole('cell', { name: 'successful' })).toBeInTheDocument();
}); });
}); });
describe('when row entry have parsable fields and labels are present', () => { describe('when row entry have parsable fields and labels are present', () => {
it('should render all headings', () => { it('should render all headings', () => {
const wrapper = setup(undefined, { entry: 'test=successful', labels: { key: 'label' } }); setup(undefined, { entry: 'test=successful', labels: { key: 'label' } });
expect(wrapper.find({ 'aria-label': 'Log labels' })).toHaveLength(1); expect(screen.getAllByLabelText('Log labels')).toHaveLength(1);
expect(wrapper.find({ 'aria-label': 'Detected fields' })).toHaveLength(1); expect(screen.getAllByLabelText('Detected fields')).toHaveLength(1);
}); });
it('should render all labels and detected fields', () => { it('should render all labels and detected fields', () => {
const wrapper = setup(undefined, { setup(undefined, { entry: 'test=successful', labels: { key: 'label' } });
entry: 'test=successful', expect(screen.getByRole('cell', { name: 'key' })).toBeInTheDocument();
labels: { key: 'label' }, expect(screen.getByRole('cell', { name: 'label' })).toBeInTheDocument();
}); expect(screen.getByRole('cell', { name: 'test' })).toBeInTheDocument();
expect(wrapper.text().includes('keylabel')).toBe(true); expect(screen.getByRole('cell', { name: 'successful' })).toBeInTheDocument();
expect(wrapper.text().includes('testsuccessful')).toBe(true);
}); });
}); });
describe('when row entry and labels are not present', () => { describe('when row entry and labels are not present', () => {
it('should render no details available message', () => { it('should render no details available message', () => {
const wrapper = setup(undefined, { entry: '' }); setup(undefined, { entry: '' });
expect(wrapper.text().includes('No details available')).toBe(true); expect(screen.getByText('No details available')).toBeInTheDocument();
}); });
it('should not render headings', () => { it('should not render headings', () => {
const wrapper = setup(undefined, { entry: '' }); setup(undefined, { entry: '' });
expect(wrapper.find({ 'aria-label': 'Log labels' })).toHaveLength(0); expect(screen.queryAllByLabelText('Log labels')).toHaveLength(0);
expect(wrapper.find({ 'aria-label': 'Detected fields' })).toHaveLength(0); expect(screen.queryAllByLabelText('Detected fields')).toHaveLength(0);
}); });
}); });
@ -104,7 +115,7 @@ describe('LogDetails', () => {
{ name: 'userId', values: ['5678'] }, { name: 'userId', values: ['5678'] },
], ],
}); });
const wrapper = setup( setup(
{ {
getFieldLinks: (field: Field, rowIndex: number) => { getFieldLinks: (field: Field, rowIndex: number) => {
if (field.config && field.config.links) { if (field.config && field.config.links) {
@ -122,10 +133,14 @@ describe('LogDetails', () => {
}, },
{ entry, dataFrame, entryFieldIndex: 0, rowIndex: 0 } { entry, dataFrame, entryFieldIndex: 0, rowIndex: 0 }
); );
expect(wrapper.find(LogDetailsRow).length).toBe(3); expect(screen.getAllByRole('table')).toHaveLength(2);
const traceIdRow = wrapper.find(LogDetailsRow).filter({ parsedKey: 'traceId' }); const rowDetailsTable = screen.getAllByRole('table')[1];
expect(traceIdRow.length).toBe(1); const rowDetailRows = within(rowDetailsTable).getAllByRole('row');
expect(traceIdRow.find('a').hostNodes().length).toBe(1); expect(rowDetailRows).toHaveLength(4); // 3 LogDetailsRow + 1 header
expect((traceIdRow.find('a').getDOMNode() as HTMLAnchorElement).href).toBe('localhost:3210/1234'); const traceIdRow = within(rowDetailsTable).getByRole('cell', { name: 'traceId' }).closest('tr');
expect(traceIdRow).toBeInTheDocument();
const link = within(traceIdRow!).getByRole('link', { name: 'link' });
expect(link).toBeInTheDocument();
expect(link).toHaveAttribute('href', 'localhost:3210/1234');
}); });
}); });