From 19a080a4d42e7db5237078040871ddff6d466959 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Thu, 14 Feb 2019 15:29:36 +0100 Subject: [PATCH] Restored loading spinner to DataPanel --- .../features/dashboard/dashgrid/DataPanel.tsx | 28 +++++++++++++------ 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/public/app/features/dashboard/dashgrid/DataPanel.tsx b/public/app/features/dashboard/dashgrid/DataPanel.tsx index 42889a4eedb..0675c7afa60 100644 --- a/public/app/features/dashboard/dashgrid/DataPanel.tsx +++ b/public/app/features/dashboard/dashgrid/DataPanel.tsx @@ -188,11 +188,7 @@ export class DataPanel extends Component { const panelData = this.getPanelData(); if (isFirstLoad && loading === LoadingState.Loading) { - return ( -
- -
- ); + return this.renderLoadingState(); } if (!queries.length) { @@ -203,9 +199,23 @@ export class DataPanel extends Component { ); } - return this.props.children({ - loading, - panelData, - }); + return ( + <> + {this.renderLoadingState()} + {this.props.children({ loading, panelData })} + + ); + } + + private renderLoadingState(): JSX.Element { + const { loading } = this.state; + if (loading === LoadingState.Loading) { + return ( +
+ +
+ ); + } + return null; } }