IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-15 01:53:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Convert tsdb request test to standard library (#29936)

Browse Source 
* Chore: Convert tsdb request test to standard library

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Emil Hessman 2020-12-20 11:53:28 +01:00 committed by GitHub
parent 408c96fee3
commit 19b2845581
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
pkg/tsdb/tsdb_test.go → pkg/tsdb/request_test.go
View File

@ -5,11 +5,11 @@ import (
"testing" "testing"
"github.com/grafana/grafana/pkg/models" "github.com/grafana/grafana/pkg/models"
. "github.com/smartystreets/goconvey/convey" "github.com/stretchr/testify/require"
) )
func TestMetricQuery(t *testing.T) { func TestHandleRequest(t *testing.T) {
Convey("When executing request with one query", t, func() { t.Run("Should return query result when handling request for query", func(t *testing.T) {
req := &TsdbQuery{ req := &TsdbQuery{
Queries: []*Query{ Queries: []*Query{
{RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "test"}}, {RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "test"}},
@ -20,15 +20,12 @@ func TestMetricQuery(t *testing.T) {
fakeExecutor.Return("A", TimeSeriesSlice{&TimeSeries{Name: "argh"}}) fakeExecutor.Return("A", TimeSeriesSlice{&TimeSeries{Name: "argh"}})
res, err := HandleRequest(context.TODO(), &models.DataSource{Id: 1, Type: "test"}, req) res, err := HandleRequest(context.TODO(), &models.DataSource{Id: 1, Type: "test"}, req)
So(err, ShouldBeNil) require.NoError(t, err)
require.NotEmpty(t, res.Results["A"].Series)
Convey("Should return query results", func() { require.Equal(t, "argh", res.Results["A"].Series[0].Name)
So(res.Results["A"].Series, ShouldNotBeEmpty)
So(res.Results["A"].Series[0].Name, ShouldEqual, "argh")
})
}) })
Convey("When executing one request with two queries from same data source", t, func() { t.Run("Should return query results when handling request for two queries with same data source", func(t *testing.T) {
req := &TsdbQuery{ req := &TsdbQuery{
Queries: []*Query{ Queries: []*Query{
{RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "test"}}, {RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "test"}},
@ -41,15 +38,14 @@ func TestMetricQuery(t *testing.T) {
fakeExecutor.Return("B", TimeSeriesSlice{&TimeSeries{Name: "barg"}}) fakeExecutor.Return("B", TimeSeriesSlice{&TimeSeries{Name: "barg"}})
res, err := HandleRequest(context.TODO(), &models.DataSource{Id: 1, Type: "test"}, req) res, err := HandleRequest(context.TODO(), &models.DataSource{Id: 1, Type: "test"}, req)
So(err, ShouldBeNil) require.NoError(t, err)
Convey("Should return query results", func() { require.Len(t, res.Results, 2)
So(len(res.Results), ShouldEqual, 2) require.Equal(t, "argh", res.Results["A"].Series[0].Name)
So(res.Results["B"].Series[0].Name, ShouldEqual, "barg") require.Equal(t, "barg", res.Results["B"].Series[0].Name)
})
}) })
Convey("When query uses data source of unknown type", t, func() { t.Run("Should return error when handling request for query with unknown type", func(t *testing.T) {
req := &TsdbQuery{ req := &TsdbQuery{
Queries: []*Query{ Queries: []*Query{
{RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "asdasdas"}}, {RefId: "A", DataSource: &models.DataSource{Id: 1, Type: "asdasdas"}},
@ -57,7 +53,7 @@ func TestMetricQuery(t *testing.T) {
} }
_, err := HandleRequest(context.TODO(), &models.DataSource{Id: 12, Type: "testjughjgjg"}, req) _, err := HandleRequest(context.TODO(), &models.DataSource{Id: 12, Type: "testjughjgjg"}, req)
So(err, ShouldNotBeNil) require.Error(t, err)
}) })
} }