IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Logs: Fix scrolling with exploreScrollableLogsContainer feature flag (#70164)

Browse Source 
correct scrolling with `exploreScrollableLogsContainer`
This commit is contained in:
Sven Grossmann 2023-06-19 13:15:22 +02:00 committed by GitHub
parent 271cdb4baa
commit 1a985c488c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
public/app/features/explore/Logs/Logs.tsx
View File

@ -136,6 +136,7 @@ class UnthemedLogs extends PureComponent<Props, State> {
cancelFlippingTimer?: number;
topLogsRef = createRef<HTMLDivElement>();
logsVolumeEventBus: EventBus;
logsContainer = createRef<HTMLDivElement>();
state: State = {
showLabels: store.getBool(SETTINGS_KEYS.showLabels, false),
@ -370,6 +371,17 @@ class UnthemedLogs extends PureComponent<Props, State> {
};
scrollIntoView = (element: HTMLElement) => {
if (config.featureToggles.exploreScrollableLogsContainer) {
this.scrollToTopLogs();
if (this.logsContainer.current) {
this.logsContainer.current.scroll({
behavior: 'smooth',
top: this.logsContainer.current.scrollTop + element.getBoundingClientRect().top - window.innerHeight / 2,
});
}
return;
}
const { scrollElement } = this.props;
if (scrollElement) {
@ -582,7 +594,7 @@ class UnthemedLogs extends PureComponent<Props, State> {
clearDetectedFields={this.clearDetectedFields}
/>
<div className={styles.logsSection}>
<div className={styles.logRows} data-testid="logRows">
<div className={styles.logRows} data-testid="logRows" ref={this.logsContainer}>
<LogRows
logRows={logRows}
deduplicatedRows={dedupedRows}