IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Update no-untranslated-strings to check tooltip and template literals (#98281)

Browse Source
This commit is contained in:
Tom Ratcliffe 2025-01-10 16:26:03 +00:00 committed by GitHub
parent 6568f3669d
commit 1ba9a27f70
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 562 additions and 223 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

780
.betterer.results
View File

File diff suppressed because it is too large Load Diff

5
packages/grafana-eslint-rules/rules/no-untranslated-strings.cjs
View File

@ -5,7 +5,7 @@ const createRule = ESLintUtils.RuleCreator(
(name) => `https://github.com/grafana/grafana/blob/main/packages/grafana-eslint-rules/README.md#${name}`
);
const propsToCheck = ['label', 'description', 'placeholder', 'aria-label', 'title', 'text'];
const propsToCheck = ['label', 'description', 'placeholder', 'aria-label', 'title', 'text', 'tooltip'];
const noUntranslatedStrings = createRule({
create(context) {
@ -17,7 +17,8 @@ const noUntranslatedStrings = createRule({
const isUntranslatedProp =
(node.value.type === 'Literal' && node.value.value !== '') ||
(node.value.type === 'JSXExpressionContainer' && node.value.expression.type === 'Literal');
(node.value.type === 'JSXExpressionContainer' &&
(node.value.expression.type === 'Literal' || node.value.expression.type === 'TemplateLiteral'));
if (isUntranslatedProp) {
return context.report({