IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-15 10:03:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix: making select to return empty list when no values are selected in multivalue mode.

Browse Source 
* Fixed error in storybook when remving selections.

* moved fix to select base instead of in story.

* updated to check for null or undefined.
This commit is contained in:
Marcus Andersson 2020-02-25 15:07:13 +01:00 committed by GitHub
parent 12f1af2956
commit 204682e9b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/grafana-ui/src/components/Forms/Select/SelectBase.tsx
View File

@ -1,4 +1,4 @@
import React from 'react';
import React, { useCallback } from 'react';
import { SelectableValue, deprecationWarning } from '@grafana/data';
// @ts-ignore
import { default as ReactSelect } from '@torkelo/react-select';
@ -178,6 +178,15 @@ export function SelectBase<T>({
}: SelectBaseProps<T>) {
const theme = useTheme();
const styles = getSelectStyles(theme);
const onChangeWithEmpty = useCallback(
(value: SelectValue<T>) => {
if (isMulti && (value === undefined || value === null)) {
return onChange([]);
}
onChange(value);
},
[isMulti]
);
let ReactSelectComponent: ReactSelect | Creatable = ReactSelect;
const creatableProps: any = {};
let asyncSelectProps: any = {};
@ -229,7 +238,7 @@ export function SelectBase<T>({
onMenuClose: onCloseMenu,
tabSelectsValue,
options,
onChange,
onChange: onChangeWithEmpty,
onBlur,
onKeyDown,
menuShouldScrollIntoView: false,