IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Loki: Update feature tracking for label browser (#59295)

Browse Source 
* update feature tracking names

* track when label browser is opened

* remove old feature tracking

* report interaction on modal close

* update

* fix type error

* revert changes to modal

* revert changes to modal

* remove close method from report interaction

* remove close type for grafana_loki_log_browser_closed

* nit pick

* add closeType to grafana_loki_label_browser_closed
This commit is contained in:
Gareth Dawson 2022-12-12 15:35:29 +00:00 committed by GitHub
parent 39a4ba4396
commit 22736cc93b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/plugins/datasource/loki/components/LokiLabelBrowser.tsx
View File

@ -187,7 +187,7 @@ export class UnthemedLokiLabelBrowser extends React.Component<BrowserProps, Brow
};
onClickRunLogsQuery = () => {
reportInteraction('grafana_loki_log_browser_closed', {
reportInteraction('grafana_loki_label_browser_closed', {
app: this.props.app,
closeType: 'showLogsButton',
});
@ -196,7 +196,7 @@ export class UnthemedLokiLabelBrowser extends React.Component<BrowserProps, Brow
};
onClickRunMetricsQuery = () => {
reportInteraction('grafana_loki_log_browser_closed', {
reportInteraction('grafana_loki_label_browser_closed', {
app: this.props.app,
closeType: 'showLogsRateButton',
});
@ -206,10 +206,6 @@ export class UnthemedLokiLabelBrowser extends React.Component<BrowserProps, Brow
};
onClickClear = () => {
reportInteraction('grafana_loki_log_browser_closed', {
app: this.props.app,
closeType: 'clearButton',
});
this.setState((state) => {
const labels: SelectableLabel[] = state.labels.map((label) => ({
...label,

4
public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx
View File

@ -73,6 +73,10 @@ export const LokiQueryEditor = React.memo<LokiQueryEditorProps>((props) => {
};
const onClickLabelBrowserButton = () => {
reportInteraction('grafana_loki_label_browser_opened', {
app: app,
});
setLabelBrowserVisible((visible) => !visible);
};

16
public/app/plugins/datasource/loki/components/LokiQueryField.tsx
View File

@ -4,7 +4,7 @@ import { Plugin, Node } from 'slate';
import { Editor } from 'slate-react';
import { CoreApp, QueryEditorProps } from '@grafana/data';
import { config, reportInteraction } from '@grafana/runtime';
import { config } from '@grafana/runtime';
import {
SlatePrism,
TypeaheadOutput,
@ -135,20 +135,6 @@ export class LokiQueryField extends React.PureComponent<LokiQueryFieldProps, Lok
}
};
onClickChooserButton = () => {
if (!this.state.labelBrowserVisible) {
reportInteraction('grafana_loki_log_browser_opened', {
app: this.props.app,
});
} else {
reportInteraction('grafana_loki_log_browser_closed', {
app: this.props.app,
closeType: 'logBrowserButton',
});
}
this.setState((state) => ({ labelBrowserVisible: !state.labelBrowserVisible }));
};
onTypeahead = async (typeahead: TypeaheadInput): Promise<TypeaheadOutput> => {
const { datasource } = this.props;

11
public/app/plugins/datasource/loki/querybuilder/components/LabelBrowserModal.tsx
View File

@ -1,6 +1,7 @@
import React, { useState, useEffect } from 'react';
import { CoreApp } from '@grafana/data';
import { reportInteraction } from '@grafana/runtime';
import { LoadingPlaceholder, Modal } from '@grafana/ui';
import { LocalStorageValueProvider } from 'app/core/components/LocalStorageValueProvider';
@ -47,8 +48,16 @@ export const LabelBrowserModal = (props: Props) => {
onClose();
};
const reportInteractionAndClose = () => {
reportInteraction('grafana_loki_label_browser_closed', {
app,
closeType: 'modalClose',
});
onClose();
};
return (
<Modal isOpen={isOpen} title="Label browser" onDismiss={onClose}>
<Modal isOpen={isOpen} title="Label browser" onDismiss={reportInteractionAndClose}>
{!labelsLoaded && <LoadingPlaceholder text="Loading labels..." />}
{labelsLoaded && !hasLogLabels && <p>No labels found.</p>}
{labelsLoaded && hasLogLabels && (