IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Combobox: only render ScrollContainer when menu is open (#96271)

Browse Source 
only render ScrollContainer when menu is open
This commit is contained in:
Ashley Harrison 2024-11-12 13:15:22 +00:00 committed by GitHub
parent 69a38c634c
commit 265342fbae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 49 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/grafana-ui/src/components/Combobox/Combobox.tsx
View File

@ -375,8 +375,9 @@ export const Combobox = <T extends string | number>(props: ComboboxProps<T>) =>
'aria-labelledby': ariaLabelledBy, 'aria-labelledby': ariaLabelledBy,
})} })}
> >
{isOpen && (
<ScrollContainer showScrollIndicators maxHeight="inherit" ref={scrollRef}> <ScrollContainer showScrollIndicators maxHeight="inherit" ref={scrollRef}>
{isOpen && !asyncError && ( {!asyncError && (
<ul style={{ height: rowVirtualizer.getTotalSize() }} className={styles.menuUlContainer}> <ul style={{ height: rowVirtualizer.getTotalSize() }} className={styles.menuUlContainer}>
{rowVirtualizer.getVirtualItems().map((virtualRow) => { {rowVirtualizer.getVirtualItems().map((virtualRow) => {
return ( return (
@ -424,6 +425,7 @@ export const Combobox = <T extends string | number>(props: ComboboxProps<T>) =>
)} )}
</div> </div>
</ScrollContainer> </ScrollContainer>
)}
</div> </div>
</div> </div>
); );