IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Trace View: Rename span detail attribute sections (#67849)

Browse Source 
* Rename span detail attribute sections

* Fix tests

* Fix more tests
This commit is contained in:
Andre Pereira 2023-05-05 15:51:13 +01:00 committed by GitHub
parent 848f1f0fb2
commit 26fc359933
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/features/explore/TraceView/TraceView.test.tsx
View File

@ -91,14 +91,14 @@ describe('TraceView', () => {
it('toggles detailState', async () => {
renderTraceViewNew();
expect(screen.queryByText(/Attributes/)).toBeFalsy();
expect(screen.queryByText(/Span Attributes/)).toBeFalsy();
const spanView = screen.getAllByText('', { selector: 'div[data-testid="span-view"]' })[0];
await userEvent.click(spanView);
expect(screen.queryByText(/Attributes/)).toBeTruthy();
expect(screen.queryByText(/Span Attributes/)).toBeTruthy();
await userEvent.click(spanView);
screen.debug(screen.queryAllByText(/Attributes/));
expect(screen.queryByText(/Attributes/)).toBeFalsy();
screen.debug(screen.queryAllByText(/Span Attributes/));
expect(screen.queryByText(/Span Attributes/)).toBeFalsy();
});
it('shows timeline ticks', () => {

4
public/app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/index.test.tsx
View File

@ -144,13 +144,13 @@ describe('<SpanDetail>', () => {
it('renders the span tags', async () => {
render(<SpanDetail {...(props as unknown as SpanDetailProps)} />);
await userEvent.click(screen.getByRole('switch', { name: /Attributes/ }));
await userEvent.click(screen.getByRole('switch', { name: /Span Attributes/ }));
expect(props.tagsToggle).toHaveBeenLastCalledWith(span.spanID);
});
it('renders the process tags', async () => {
render(<SpanDetail {...(props as unknown as SpanDetailProps)} />);
await userEvent.click(screen.getByRole('switch', { name: /Resource/ }));
await userEvent.click(screen.getByRole('switch', { name: /Resource Attributes/ }));
expect(props.processToggle).toHaveBeenLastCalledWith(span.spanID);
});

4
public/app/features/explore/TraceView/components/TraceTimelineViewer/SpanDetail/index.tsx
View File

@ -250,7 +250,7 @@ export default function SpanDetail(props: SpanDetailProps) {
<div>
<AccordianKeyValues
data={tags}
label="Attributes"
label="Span Attributes"
linksGetter={linksGetter}
isOpen={isTagsOpen}
onToggle={() => tagsToggle(spanID)}
@ -259,7 +259,7 @@ export default function SpanDetail(props: SpanDetailProps) {
<AccordianKeyValues
className={ubMb1}
data={process.tags}
label="Resource"
label="Resource Attributes"
linksGetter={linksGetter}
isOpen={isProcessOpen}
onToggle={() => processToggle(spanID)}