From 2aa6f4d17b77023739fe119a62f6a41508fe05e2 Mon Sep 17 00:00:00 2001 From: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Date: Tue, 19 Apr 2022 15:29:27 +0200 Subject: [PATCH] Loki: Fix showing of default visual query only if no expression (#47764) * AutoSizeInput: Fix updating of value * Update * Revert "Update" This reverts commit a3b527e0c68934d1965a3bea3715196e45822d19. * Revert "AutoSizeInput: Fix updating of value" This reverts commit d4b4ae0a10ea48c70a6ca5abfc73df7f47c90a18. * Fix showing of default visual query only if no expression * Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx * Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx * Update * Update --- .../components/LokiQueryBuilderContainer.tsx | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx index 3a428319d78..bc5e93b3c38 100644 --- a/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx +++ b/public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderContainer.tsx @@ -26,11 +26,15 @@ export interface State { export function LokiQueryBuilderContainer(props: Props) { const { query, onChange, onRunQuery, datasource } = props; const [state, dispatch] = useReducer(stateSlice.reducer, { - expr: '', - visQuery: { - labels: [], - operations: [{ id: '__line_contains', params: [''] }], - }, + expr: query.expr, + // Use initial visual query only if query.expr is empty string + visQuery: + query.expr === '' + ? { + labels: [], + operations: [{ id: '__line_contains', params: [''] }], + } + : undefined, }); // Only rebuild visual query if expr changes from outside @@ -62,7 +66,7 @@ export function LokiQueryBuilderContainer(props: Props) { } const stateSlice = createSlice({ - name: 'prom-builder-container', + name: 'loki-builder-container', initialState: { expr: '' } as State, reducers: { visualQueryChange: (state, action: PayloadAction<{ visQuery: LokiVisualQuery; expr: string }>) => {