IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

DashboardScene: Add rows keyboard shortcuts (#90275)

Browse Source 
* DashboardScene: Add rows keyboard shortcuts

* e2e test
This commit is contained in:
Dominik Prokop 2024-07-12 15:13:22 +02:00 committed by GitHub
parent 3a51260ef9
commit 2d35b11323
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 74 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
e2e/scenes/dashboards-suite/dashboard-keybindings.spec.ts Normal file
View File

@ -0,0 +1,24 @@
import { e2e } from '../utils';
describe('Dashboard keybindings', () => {
beforeEach(() => {
e2e.flows.login(Cypress.env('USERNAME'), Cypress.env('PASSWORD'));
});
it('should collapse and expand all rows', () => {
e2e.flows.openDashboard({ uid: 'Repeating-rows-uid/repeating-rows' });
e2e.components.Panels.Panel.content().should('have.length', 5);
e2e.components.Panels.Panel.title('server = A, pod = Bob').should('be.visible');
e2e.components.Panels.Panel.title('server = B, pod = Bob').should('be.visible');
cy.get('body').type('d').type('{shift}c');
e2e.components.Panels.Panel.content().should('have.length', 0);
e2e.components.Panels.Panel.title('server = A, pod = Bob').should('not.exist');
e2e.components.Panels.Panel.title('server = B, pod = Bob').should('not.exist');
cy.get('body').type('d').type('{shift}e');
e2e.components.Panels.Panel.content().should('have.length', 6);
e2e.components.Panels.Panel.title('server = A, pod = Bob').should('be.visible');
e2e.components.Panels.Panel.title('server = B, pod = Bob').should('be.visible');
});
});

34
public/app/features/dashboard-scene/scene/DashboardScene.tsx
View File

@ -877,6 +877,40 @@ export class DashboardScene extends SceneObjectBase<DashboardSceneState> {
this.setState({ isDirty: false });
locationService.replace('/');
}
public collapseAllRows() {
if (!(this.state.body instanceof SceneGridLayout)) {
throw new Error('Dashboard scene layout is not SceneGridLayout');
}
const sceneGridLayout = this.state.body;
sceneGridLayout.state.children.forEach((child) => {
if (!(child instanceof SceneGridRow)) {
return;
}
if (!child.state.isCollapsed) {
sceneGridLayout.toggleRow(child);
}
});
}
public expandAllRows() {
if (!(this.state.body instanceof SceneGridLayout)) {
throw new Error('Dashboard scene layout is not SceneGridLayout');
}
const sceneGridLayout = this.state.body;
sceneGridLayout.state.children.forEach((child) => {
if (!(child instanceof SceneGridRow)) {
return;
}
if (child.state.isCollapsed) {
sceneGridLayout.toggleRow(child);
}
});
}
}
export class DashboardVariableDependency implements SceneVariableDependencyConfigLike {

18
public/app/features/dashboard-scene/scene/keyboardShortcuts.ts
View File

@ -167,12 +167,26 @@ export function setupKeyboardShortcuts(scene: DashboardScene) {
}
}),
});
// collapse all rows
keybindings.addBinding({
key: 'd shift+c',
onTrigger: () => {
scene.collapseAllRows();
},
});
// expand all rows
keybindings.addBinding({
key: 'd shift+e',
onTrigger: () => {
scene.expandAllRows();
},
});
}
// toggle all panel legends (TODO)
// toggle all exemplars (TODO)
// collapse all rows (TODO)
// expand all rows (TODO)
return () => {
keybindings.removeAll();