IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Explore: Fix running queries without a datasource property set (#40805)

Browse Source 
* Explore: Fix running queries without a datasource property set

* fix test

* adjust test
This commit is contained in:
Giordano Ricci
2021-10-25 14:25:17 +01:00
committed by GitHub
parent cc271b0a42
commit 2ee54b7ffe
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/core/utils/explore.ts
+5 -2
View File
@@ -277,9 +277,12 @@ export function ensureQueries(queries?: DataQuery[]): DataQuery[] {
}
/**
* A target is non-empty when it has keys (with non-empty values) other than refId, key and context.
* A target is non-empty when it has keys (with non-empty values) other than refId, key, context and datasource.
* FIXME: While this is reasonable for practical use cases, a query without any propery might still be "non-empty"
* in its own scope, for instance when there's no user input needed. This might be the case for an hypothetic datasource in
* which query options are only set in its config and the query object itself, as generated from its query editor it's always "empty"
*/
const validKeys = ['refId', 'key', 'context'];
const validKeys = ['refId', 'key', 'context', 'datasource'];
export function hasNonEmptyQuery<TQuery extends DataQuery>(queries: TQuery[]): boolean {
return (
queries &&