IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Tempo: Reset tag value when key changed in Search tab (#82365)

Browse Source 
Reset tag value when key changed
This commit is contained in:
Joey 2024-02-15 09:33:15 +00:00 committed by GitHub
parent 808be099a7
commit 2ef17efaf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx
View File

@ -125,19 +125,19 @@ describe('SearchField', () => {
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
const tag22 = await screen.findByText('tag22'); const tag22 = await screen.findByText('tag22');
await user.click(tag22); await user.click(tag22);
expect(updateFilter).toHaveBeenCalledWith({ ...filter, tag: 'tag22' }); expect(updateFilter).toHaveBeenCalledWith({ ...filter, tag: 'tag22', value: [] });
// Select tag1 as the tag // Select tag1 as the tag
await user.click(select); await user.click(select);
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
const tag1 = await screen.findByText('tag1'); const tag1 = await screen.findByText('tag1');
await user.click(tag1); await user.click(tag1);
expect(updateFilter).toHaveBeenCalledWith({ ...filter, tag: 'tag1' }); expect(updateFilter).toHaveBeenCalledWith({ ...filter, tag: 'tag1', value: [] });
// Remove the tag // Remove the tag
const tagRemove = await screen.findByLabelText('select-clear-value'); const tagRemove = await screen.findByLabelText('select-clear-value');
await user.click(tagRemove); await user.click(tagRemove);
expect(updateFilter).toHaveBeenCalledWith({ ...filter, value: undefined }); expect(updateFilter).toHaveBeenCalledWith({ ...filter, value: [] });
} }
}); });

2
public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx
View File

@ -159,7 +159,7 @@ const SearchField = ({
)} )}
value={filter.tag} value={filter.tag}
onChange={(v) => { onChange={(v) => {
updateFilter({ ...filter, tag: v?.value }); updateFilter({ ...filter, tag: v?.value, value: [] });
}} }}
placeholder="Select tag" placeholder="Select tag"
isClearable isClearable