IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-16 18:34:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

IDFowrarding: ignore logging context canceled errors (#85141)

Browse Source
This commit is contained in:
Karl Persson 2024-03-26 11:36:44 +01:00 committed by GitHub
parent 5ebf2d08f6
commit 2f5e3023c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/services/auth/idimpl/service.go
View File

@ -159,8 +159,10 @@ func (s *Service) hook(ctx context.Context, identity *authn.Identity, _ *authn.R
// FIXME(kalleep): we should probably lazy load this
token, err := s.SignIdentity(ctx, identity)
if err != nil {
namespace, id := identity.GetNamespacedID()
s.logger.FromContext(ctx).Error("Failed to sign id token", "err", err, "namespace", namespace, "id", id)
if shouldLogErr(err) {
namespace, id := identity.GetNamespacedID()
s.logger.FromContext(ctx).Error("Failed to sign id token", "err", err, "namespace", namespace, "id", id)
}
// for now don't return error so we don't break authentication from this hook
return nil
}
@ -180,3 +182,7 @@ func getSubject(namespace, identifier string) string {
func prefixCacheKey(key string) string {
return fmt.Sprintf("%s-%s", cachePrefix, key)
}
func shouldLogErr(err error) bool {
return !errors.Is(err, context.Canceled)
}