IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-12 00:25:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

BarGauge: Show empty bar when value, minValue and maxValue are all equal (#53314)

Browse Source 
* prevent returning NaN from getValuePercent

* return 0 instead of NaN always
This commit is contained in:
Ashley Harrison 2022-08-08 09:11:46 +01:00 committed by GitHub
parent 42f9a6e67b
commit 2fea3f0d9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/grafana-ui/src/components/BarGauge/BarGauge.test.tsx
View File

@ -159,6 +159,10 @@ describe('BarGauge', () => {
it('-30 to 30 and value 30', () => {
expect(getValuePercent(30, -30, 30)).toEqual(1);
});
it('returns 0 if the min, max and value are all the same value', () => {
expect(getValuePercent(25, 25, 25)).toEqual(0);
});
});
describe('Vertical bar', () => {

4
packages/grafana-ui/src/components/BarGauge/BarGauge.tsx
View File

@ -430,7 +430,9 @@ export function getCellColor(
}
export function getValuePercent(value: number, minValue: number, maxValue: number): number {
return Math.min((value - minValue) / (maxValue - minValue), 1);
// Need special logic for when minValue === maxValue === value to prevent returning NaN
const valueRatio = Math.min((value - minValue) / (maxValue - minValue), 1);
return isNaN(valueRatio) ? 0 : valueRatio;
}
/**