From 304185f682cd94133374dce604e06f3b78b8b00b Mon Sep 17 00:00:00 2001 From: Shirley <4163034+fridgepoet@users.noreply.github.com> Date: Fri, 25 Feb 2022 12:20:07 +0100 Subject: [PATCH] CloudWatch: Fix running go test with count (#45892) --- pkg/tsdb/cloudwatch/get_metric_data_executor_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/tsdb/cloudwatch/get_metric_data_executor_test.go b/pkg/tsdb/cloudwatch/get_metric_data_executor_test.go index 46612e4ed43..dc9c3893077 100644 --- a/pkg/tsdb/cloudwatch/get_metric_data_executor_test.go +++ b/pkg/tsdb/cloudwatch/get_metric_data_executor_test.go @@ -12,10 +12,10 @@ import ( "github.com/stretchr/testify/require" ) -var counter = 1 - type cloudWatchFakeClient struct { cloudwatchiface.CloudWatchAPI + + counterForGetMetricDataWithContext int } func (client *cloudWatchFakeClient) GetMetricDataWithContext(ctx aws.Context, input *cloudwatch.GetMetricDataInput, opts ...request.Option) (*cloudwatch.GetMetricDataOutput, error) { @@ -23,13 +23,13 @@ func (client *cloudWatchFakeClient) GetMetricDataWithContext(ctx aws.Context, in res := []*cloudwatch.MetricDataResult{{ Values: []*float64{aws.Float64(12.3), aws.Float64(23.5)}, }} - if counter == 0 { + if client.counterForGetMetricDataWithContext == 0 { nextToken = "" res = []*cloudwatch.MetricDataResult{{ Values: []*float64{aws.Float64(100)}, }} } - counter-- + client.counterForGetMetricDataWithContext-- return &cloudwatch.GetMetricDataOutput{ MetricDataResults: res, NextToken: aws.String(nextToken), @@ -39,7 +39,7 @@ func (client *cloudWatchFakeClient) GetMetricDataWithContext(ctx aws.Context, in func TestGetMetricDataExecutorTest(t *testing.T) { executor := &cloudWatchExecutor{} inputs := &cloudwatch.GetMetricDataInput{MetricDataQueries: []*cloudwatch.MetricDataQuery{}} - res, err := executor.executeRequest(context.Background(), &cloudWatchFakeClient{}, inputs) + res, err := executor.executeRequest(context.Background(), &cloudWatchFakeClient{counterForGetMetricDataWithContext: 1}, inputs) require.NoError(t, err) require.Len(t, res, 2) require.Len(t, res[0].MetricDataResults[0].Values, 2)