IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Azure OAuth: silent fail on getting groups (#49909)

Browse Source
This commit is contained in:
Gabriel MABILLE 2022-06-01 17:10:47 +02:00 committed by GitHub
parent e5fab2dec8
commit 3049534c40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/login/social/azuread_oauth.go
View File

@ -5,6 +5,7 @@ import (
"encoding/json" "encoding/json"
"errors" "errors"
"fmt" "fmt"
"io"
"net/http" "net/http"
"strings" "strings"
@ -214,9 +215,11 @@ func extractGroups(client *http.Client, claims azureClaims, token *oauth2.Token)
if res.StatusCode != http.StatusOK { if res.StatusCode != http.StatusOK {
if res.StatusCode == http.StatusForbidden { if res.StatusCode == http.StatusForbidden {
logger.Warn("AzureAD OAuh: Token need GroupMember.Read.All permission to fetch all groups") logger.Warn("AzureAD OAuh: Token need GroupMember.Read.All permission to fetch all groups")
return []string{}, nil } else {
body, _ := io.ReadAll(res.Body)
logger.Warn("AzureAD OAuh: could not fetch user groups", "code", res.StatusCode, "body", string(body))
} }
return nil, errors.New("error fetching groups") return []string{}, nil
} }
var body getAzureGroupResponse var body getAzureGroupResponse