Storage: Add blob storage interfaces (#90932)

Co-authored-by: Jean-Philippe Quémémer <jeanphilippe.quemener@grafana.com>

pkg/storage/unified/sql/server.go

@@ -3,6 +3,8 @@ package sql
 import (
 	"context"
 	"errors"
+	"os"
+	"strings"
 
 	"github.com/grafana/authlib/claims"
 	infraDB "github.com/grafana/grafana/pkg/infra/db"
@@ -11,12 +13,28 @@ import (
 	"github.com/grafana/grafana/pkg/setting"
 	"github.com/grafana/grafana/pkg/storage/unified/resource"
 	"github.com/grafana/grafana/pkg/storage/unified/sql/db/dbimpl"
+	"github.com/prometheus/client_golang/prometheus"
 )
 
 // Creates a new ResourceServer
-func NewResourceServer(ctx context.Context, db infraDB.DB, cfg *setting.Cfg, features featuremgmt.FeatureToggles, tracer tracing.Tracer) (resource.ResourceServer, error) {
+func NewResourceServer(ctx context.Context, db infraDB.DB, cfg *setting.Cfg, features featuremgmt.FeatureToggles, tracer tracing.Tracer, reg prometheus.Registerer) (resource.ResourceServer, error) {
+	apiserverCfg := cfg.SectionWithEnvOverrides("grafana-apiserver")
 	opts := resource.ResourceServerOptions{
 		Tracer: tracer,
+		Blob: resource.BlobConfig{
+			URL: apiserverCfg.Key("blob_url").MustString(""),
+		},
+		Reg: reg,
+	}
+
+	// Support local file blob
+	if strings.HasPrefix(opts.Blob.URL, "./data/") {
+		dir := strings.Replace(opts.Blob.URL, "./data", cfg.DataPath, 1)
+		err := os.MkdirAll(dir, 0700)
+		if err != nil {
+			return nil, err
+		}
+		opts.Blob.URL = "file:///" + dir
 	}
 
 	eDB, err := dbimpl.ProvideResourceDB(db, cfg, tracer)

pkg/storage/unified/sql/service.go

@@ -46,6 +46,7 @@ type service struct {
 	authenticator interceptors.Authenticator
 
 	log log.Logger
+	reg prometheus.Registerer
 }
 
 func ProvideUnifiedStorageGrpcService(
@@ -53,6 +54,7 @@ func ProvideUnifiedStorageGrpcService(
 	features featuremgmt.FeatureToggles,
 	db infraDB.DB,
 	log log.Logger,
+	reg prometheus.Registerer,
 ) (UnifiedStorageGrpcService, error) {
 	tracingCfg, err := tracing.ProvideTracingConfig(cfg)
 	if err != nil {
@@ -75,6 +77,7 @@ func ProvideUnifiedStorageGrpcService(
 		tracing:       tracing,
 		db:            db,
 		log:           log,
+		reg:           reg,
 	}
 
 	// This will be used when running as a dskit service
@@ -84,7 +87,7 @@ func ProvideUnifiedStorageGrpcService(
 }
 
 func (s *service) start(ctx context.Context) error {
-	server, err := NewResourceServer(ctx, s.db, s.cfg, s.features, s.tracing)
+	server, err := NewResourceServer(ctx, s.db, s.cfg, s.features, s.tracing, s.reg)
 	if err != nil {
 		return err
 	}
@@ -101,6 +104,7 @@ func (s *service) start(ctx context.Context) error {
 	srv := s.handler.GetServer()
 	resource.RegisterResourceStoreServer(srv, server)
 	resource.RegisterResourceIndexServer(srv, server)
+	resource.RegisterBlobStoreServer(srv, server)
 	resource.RegisterDiagnosticsServer(srv, server)
 	grpc_health_v1.RegisterHealthServer(srv, healthService)
 

pkg/storage/unified/sql/test/integration_test.go

@@ -5,6 +5,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/prometheus/client_golang/prometheus"
 	"github.com/stretchr/testify/require"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/credentials/insecure"
@@ -350,7 +351,7 @@ func TestClientServer(t *testing.T) {
 
 	features := featuremgmt.WithFeatures()
 
-	svc, err := sql.ProvideUnifiedStorageGrpcService(cfg, features, dbstore, nil)
+	svc, err := sql.ProvideUnifiedStorageGrpcService(cfg, features, dbstore, nil, prometheus.NewPedanticRegistry())
 	require.NoError(t, err)
 	var client resource.ResourceStoreClient