IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

AzureMonitor: Fix crash from infinite render loop (#37924)

Browse Source
This commit is contained in:
Josh Hunt 2021-08-17 11:50:37 +01:00 committed by GitHub
parent 697ac937c6
commit 368da73ac4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
public/app/plugins/datasource/grafana-azure-monitor-datasource/components/MetricsQueryEditor/dataHooks.ts
View File

@ -69,10 +69,15 @@ export const useSubscriptions: DataHook = (query, datasource, onChange, setError
); );
useEffect(() => { useEffect(() => {
if (!subscription && defaultSubscription && hasOption(subscriptionOptions, defaultSubscription)) { // Return early if subscriptions havent loaded, or if the query already has a subscription
onChange(setSubscriptionID(query, defaultSubscription)); if (!subscriptionOptions.length || (subscription && hasOption(subscriptionOptions, subscription))) {
} else if ((!subscription && subscriptionOptions.length) || subscriptionOptions.length === 1) { return;
onChange(setSubscriptionID(query, subscriptionOptions[0].value)); }
const defaultSub = defaultSubscription || subscriptionOptions[0].value;
if (!subscription && defaultSub && hasOption(subscriptionOptions, defaultSub)) {
onChange(setSubscriptionID(query, defaultSub));
} }
}, [subscriptionOptions, query, subscription, defaultSubscription, onChange]); }, [subscriptionOptions, query, subscription, defaultSubscription, onChange]);