IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2024-11-22 08:56:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

BarChart: Show "No data" message for zero-length frames (#79844)

Browse Source
This commit is contained in:
Leon Sorokin 2023-12-22 22:04:50 -06:00 committed by GitHub
parent feb7b38fba
commit 36a3508a0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
public/app/plugins/panel/barchart/utils.test.ts
View File

@ -158,13 +158,29 @@ describe('BarChart utils', () => {
});
describe('prepareGraphableFrames', () => {
it('will warn when there is no data in the response', () => {
it('will warn when there is no frames in the response', () => {
const result = prepareBarChartDisplayValues([], createTheme(), { stacking: StackingMode.None } as Options);
const warning = assertIsDefined('warn' in result ? result : null);
expect(warning.warn).toEqual('No data in response');
});
it('will warn when there is no data in the response', () => {
const result = prepareBarChartDisplayValues(
[
{
length: 0,
fields: [],
},
],
createTheme(),
{ stacking: StackingMode.None } as Options
);
const warning = assertIsDefined('warn' in result ? result : null);
expect(warning.warn).toEqual('No data in response');
});
it('will warn when there is no string or time field', () => {
const df = new MutableDataFrame({
fields: [

2
public/app/plugins/panel/barchart/utils.ts
View File

@ -375,7 +375,7 @@ export function prepareBarChartDisplayValues(
theme: GrafanaTheme2,
options: Options
): BarChartDisplayValues | BarChartDisplayWarning {
if (!series?.length) {
if (!series.length || series.every((fr) => fr.length === 0)) {
return { warn: 'No data in response' };
}