Datasource: Remove support for unencrypted passwords (#49987)

* Datasource: Remove support for unencrypted passwords

* regenerate swagger

* [WIP] Remove references to datasource password and basic auth password fields (#50015)

* try delete moar tings

* delete provisioning stuff

* remove from yaml

* update snapshots

* remove lingering snapshot fields

* fix ds http settings

* Re-generate swagger and fix swagger-api-spec make target

Co-authored-by: Will Browne <will.browne@grafana.com>
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>

public/app/features/datasources/__mocks__/dataSourcesMocks.ts

@@ -13,7 +13,6 @@ export const getMockDataSources = (amount: number) => {
       jsonData: { authType: 'credentials', defaultRegion: 'eu-west-2' },
       name: `dataSource-${i}`,
       orgId: 1,
-      password: '',
       readOnly: false,
       type: 'cloudwatch',
       typeLogoUrl: 'public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png',
@@ -30,7 +29,6 @@ export const getMockDataSource = (): DataSourceSettings => {
     access: '',
     basicAuth: false,
     basicAuthUser: '',
-    basicAuthPassword: '',
     withCredentials: false,
     database: '',
     id: 13,
@@ -40,7 +38,6 @@ export const getMockDataSource = (): DataSourceSettings => {
     name: 'gdev-cloudwatch',
     typeName: 'Cloudwatch',
     orgId: 1,
-    password: '',
     readOnly: false,
     type: 'cloudwatch',
     typeLogoUrl: 'public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png',

public/app/features/datasources/__snapshots__/DataSourcesListPage.test.tsx.snap

@@ -43,7 +43,6 @@ exports[`Render should render action bar and datasources 1`] = `
             },
             "name": "dataSource-0",
             "orgId": 1,
-            "password": "",
             "readOnly": false,
             "type": "cloudwatch",
             "typeLogoUrl": "public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png",
@@ -62,7 +61,6 @@ exports[`Render should render action bar and datasources 1`] = `
             },
             "name": "dataSource-1",
             "orgId": 1,
-            "password": "",
             "readOnly": false,
             "type": "cloudwatch",
             "typeLogoUrl": "public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png",
@@ -81,7 +79,6 @@ exports[`Render should render action bar and datasources 1`] = `
             },
             "name": "dataSource-2",
             "orgId": 1,
-            "password": "",
             "readOnly": false,
             "type": "cloudwatch",
             "typeLogoUrl": "public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png",
@@ -100,7 +97,6 @@ exports[`Render should render action bar and datasources 1`] = `
             },
             "name": "dataSource-3",
             "orgId": 1,
-            "password": "",
             "readOnly": false,
             "type": "cloudwatch",
             "typeLogoUrl": "public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png",
@@ -119,7 +115,6 @@ exports[`Render should render action bar and datasources 1`] = `
             },
             "name": "dataSource-4",
             "orgId": 1,
-            "password": "",
             "readOnly": false,
             "type": "cloudwatch",
             "typeLogoUrl": "public/app/plugins/datasource/cloudwatch/img/amazon-web-services.png",

public/app/features/datasources/mocks.ts

@@ -11,11 +11,9 @@ export function createDatasourceSettings<T>(jsonData: T): DataSourceSettings<T>
     typeName: 'Datasource',
     access: 'server',
     url: 'http://localhost',
-    password: '',
     user: '',
     database: '',
     basicAuth: false,
-    basicAuthPassword: '',
     basicAuthUser: '',
     isDefault: false,
     jsonData,

public/app/features/datasources/state/navModel.ts

@@ -154,7 +154,6 @@ export function getDataSourceLoadingNav(pageName: string): NavModel {
       access: '',
       basicAuth: false,
       basicAuthUser: '',
-      basicAuthPassword: '',
       withCredentials: false,
       database: '',
       id: 1,
@@ -163,7 +162,6 @@ export function getDataSourceLoadingNav(pageName: string): NavModel {
       jsonData: { authType: 'credentials', defaultRegion: 'eu-west-2' },
       name: 'Loading',
       orgId: 1,
-      password: '',
       readOnly: false,
       type: loadingDSType,
       typeName: loadingDSType,