Kindsys: Unify plugins, pfs with kind framework (#61192)

* New pfs impl

* Reached codegen parity with old system

* Update all models.cue inputs

* Rename all models.cue files

* Remove unused prefixfs

* Changes Queries->DataQuery schema interface

* Recodegen

* All tests passing, nearly good now

* Add SchemaInterface to kindsys props

* Add pascal name deriver

* Relocate plugin cue files again

* Clarify use of injected fields

* Remove unnecessary aliasing

* Move DataQuery into mudball

* Allow forcing ExpandReferences on go type generation

* Move DataQuery def into kindsys, add generator to copy it to common

* Fix copy generator to replace package name correctly

* Fix duplicate type, test failure

* Fix linting issues

pkg/plugins/codegen/jenny_plugintreelist.go

@@ -14,7 +14,7 @@ import (
 const prefix = "github.com/grafana/grafana/public/app/plugins"
 
 // PluginTreeListJenny creates a [codejen.ManyToOne] that produces Go code
-// for loading a [pfs.TreeList] given [*kindsys.PluginDecl] as inputs.
+// for loading a [pfs.PluginList] given [*kindsys.PluginDecl] as inputs.
 func PluginTreeListJenny() codejen.ManyToOne[*pfs.PluginDecl] {
 	outputFile := filepath.Join("pkg", "plugins", "pfs", "corelist", "corelist_load_gen.go")
 

pkg/plugins/codegen/tmpl/plugin_registry.tmpl

@@ -9,22 +9,22 @@ import (
 	"github.com/grafana/thema"
 )
 
-func makeTreeOrPanic(path string, pkgname string, rt *thema.Runtime) *pfs.Tree {
+func parsePluginOrPanic(path string, pkgname string, rt *thema.Runtime) pfs.ParsedPlugin {
   sub, err := fs.Sub(grafana.CueSchemaFS, path)
   if err != nil {
     panic("could not create fs sub to " + path)
   }
-  tree, err := pfs.ParsePluginFS(sub, rt)
+  pp, err := pfs.ParsePluginFS(sub, rt)
   if err != nil {
     panic(fmt.Sprintf("error parsing plugin metadata for %s: %s", pkgname, err))
   }
-  return tree
+  return pp
 }
 
-func coreTreeList(rt *thema.Runtime) pfs.TreeList{
-  return pfs.TreeList{
+func corePlugins(rt *thema.Runtime) []pfs.ParsedPlugin{
+  return []pfs.ParsedPlugin{
     {{- range .Plugins }}
-    makeTreeOrPanic("{{ .Path }}", "{{ .PkgName }}", rt),
+    parsePluginOrPanic("{{ .Path }}", "{{ .PkgName }}", rt),
     {{- end }}
   }
 }

pkg/plugins/codegen/util_ts.go

@@ -14,7 +14,10 @@ import (
 // indicates the import path should be dropped in the conversion to TS. Imports
 // not present in the list are not not allowed, and code generation will fail.
 var importMap = map[string]string{
-	"github.com/grafana/thema":                                      "",
+	"github.com/grafana/thema": "",
+
+	"github.com/grafana/grafana/pkg/kindsys":                        "",
+	"github.com/grafana/grafana/pkg/plugins/pfs":                    "",
 	"github.com/grafana/grafana/packages/grafana-schema/src/common": "@grafana/schema",
 }