A11y/Dashboard: Fix a few more miscellaneous fastpass issues (#40328)

See #39429
This commit is contained in:
kay delaney 2021-10-12 14:35:48 +01:00 committed by GitHub
parent b0391d4933
commit 3c52df960a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions

View File

@ -215,7 +215,7 @@ const AddPanelWidgetHandle: React.FC<AddPanelWidgetHandleProps> = ({ children, o
<div className={cx(styles.headerRow, 'grid-drag-handle')}>
{onBack && (
<div className={styles.backButton}>
<IconButton name="arrow-left" onClick={onBack} surface="header" size="xl" />
<IconButton aria-label="Go back" name="arrow-left" onClick={onBack} surface="header" size="xl" />
</div>
)}
{!onBack && (

View File

@ -136,11 +136,11 @@ export class ShareExport extends PureComponent<Props, State> {
<>
<p className="share-modal-info-text">Export this dashboard.</p>
<Field label="Export for sharing externally">
<Switch value={shareExternally} onChange={this.onShareExternallyChange} />
<Switch id="share-externally-toggle" value={shareExternally} onChange={this.onShareExternallyChange} />
</Field>
{config.featureToggles.trimDefaults && (
<Field label="Export with default values removed">
<Switch value={trimDefaults} onChange={this.onTrimDefaultsChange} />
<Switch id="trim-defaults-toggle" value={trimDefaults} onChange={this.onTrimDefaultsChange} />
</Field>
)}
<Modal.ButtonRow>

View File

@ -223,10 +223,11 @@ export class ShareSnapshot extends PureComponent<Props, State> {
</p>
</div>
<Field label="Snapshot name">
<Input width={30} value={snapshotName} onChange={this.onSnapshotNameChange} />
<Input id="snapshot-name-input" width={30} value={snapshotName} onChange={this.onSnapshotNameChange} />
</Field>
<Field label="Expire">
<Select
inputId="expire-select-input"
menuShouldPortal
width={30}
options={expireOptions}
@ -239,7 +240,7 @@ export class ShareSnapshot extends PureComponent<Props, State> {
description="You might need to configure the timeout value if it takes a long time to collect your dashboard
metrics."
>
<Input type="number" width={21} value={timeoutSeconds} onChange={this.onTimeoutChange} />
<Input id="timeout-input" type="number" width={21} value={timeoutSeconds} onChange={this.onTimeoutChange} />
</Field>
<Modal.ButtonRow>