IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix/add default props to prom query editor (#21908)

Browse Source 
* Plugins: Add default query to PromQueryEditor

* Plugins: Update PromQueryEditor snapshot

* Plugins: Use Partial for default PromQuery
This commit is contained in:
Alex Khomenko 2020-02-04 11:37:18 +02:00 committed by GitHub
parent bb8e15ceab
commit 3d8317a747
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/plugins/datasource/prometheus/components/PromQueryEditor.tsx
View File

@ -37,7 +37,9 @@ export class PromQueryEditor extends PureComponent<Props, State> {
constructor(props: Props) {
super(props);
const { query } = props;
// Use default query to prevent undefined input values
const defaultQuery: Partial<PromQuery> = { expr: '', legendFormat: '', interval: '' };
const query = Object.assign({}, defaultQuery, props.query);
this.query = query;
// Query target properties that are fully controlled inputs
this.state = {

5
public/app/plugins/datasource/prometheus/components/__snapshots__/PromQueryEditor.test.tsx.snap
View File

@ -38,6 +38,7 @@ exports[`Render PromQueryEditor with basic options should render 1`] = `
onChange={[Function]}
placeholder="legend format"
type="text"
value=""
/>
</div>
<div
@ -62,7 +63,9 @@ exports[`Render PromQueryEditor with basic options should render 1`] = `
className="gf-form-input width-8"
onBlur={[Function]}
onChange={[Function]}
placeholder=""
type="text"
value=""
/>
</div>
<div
@ -205,6 +208,8 @@ exports[`Render PromQueryEditor with basic options should render 1`] = `
query={
Object {
"expr": "",
"interval": "",
"legendFormat": "",
"refId": "A",
}
}