IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2024-11-26 19:00:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix for unsaved changes popup on tab close/refresh

Browse Source 
Incorrect return values in onbeforeunload event handler mean that the
unsaved changes popup is shown despite there being no changes.
This commit is contained in:
Daniel Lee 2018-01-09 14:42:42 +01:00
parent 04b9752932
commit 3ea63a1064
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/features/dashboard/unsaved_changes_srv.ts
View File

@ -35,12 +35,12 @@ export class Tracker {
$window.onbeforeunload = () => { $window.onbeforeunload = () => {
if (this.ignoreChanges()) { if (this.ignoreChanges()) {
return ''; return null;
} }
if (this.hasChanges()) { if (this.hasChanges()) {
return 'There are unsaved changes to this dashboard'; return 'There are unsaved changes to this dashboard';
} }
return ''; return null;
}; };
scope.$on('$locationChangeStart', (event, next) => { scope.$on('$locationChangeStart', (event, next) => {