IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

FieldOverride: Fixed number override so that it return undefined for null/undefined values and not NaN (#23344)

Browse Source 
* FieldOverride: Fixed number override so that it return undefined for null/undefined values and not NaN

* Made process function be able to return undefined an null
This commit is contained in:
Torkel Ödegaard 2020-04-05 06:52:33 +02:00 committed by GitHub
parent dea91c1fd6
commit 3fae28be52
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grafana-data/src/field/overrides/processors.ts
View File

@ -17,11 +17,11 @@ export const numberOverrideProcessor = (
context: FieldOverrideContext, context: FieldOverrideContext,
settings?: NumberFieldConfigSettings settings?: NumberFieldConfigSettings
) => { ) => {
const v = parseFloat(`${value}`); if (value === undefined || value === null) {
if (settings && settings.max && v > settings.max) { return undefined;
// ????
} }
return v;
return parseFloat(value);
}; };
export interface DataLinksFieldConfigSettings {} export interface DataLinksFieldConfigSettings {}

2
packages/grafana-data/src/types/fieldOverrides.ts
View File

@ -69,7 +69,7 @@ export interface FieldPropertyEditorItem<TOptions = any, TValue = any, TSettings
override: ComponentType<FieldOverrideEditorProps<TValue, TSettings>>; override: ComponentType<FieldOverrideEditorProps<TValue, TSettings>>;
// Convert the override value to a well typed value // Convert the override value to a well typed value
process: (value: any, context: FieldOverrideContext, settings?: TSettings) => TValue; process: (value: any, context: FieldOverrideContext, settings?: TSettings) => TValue | undefined | null;
// Checks if field should be processed // Checks if field should be processed
shouldApply: (field: Field) => boolean; shouldApply: (field: Field) => boolean;