Build: Separate frontend linting from frontend testing (#39808)

* Create new lint-frontend step

* Use lint-frontend step / separate from test-frontend

* Fix typo
This commit is contained in:
Dimitris Sotirakis
2021-09-30 09:56:08 +02:00
committed by GitHub
parent 738d5e499e
commit 4017c5c800
6 changed files with 132 additions and 11 deletions
+2
View File
@@ -1,6 +1,7 @@
load(
'scripts/drone/steps/lib.star',
'lint_backend_step',
'lint_frontend_step',
'codespell_step',
'shellcheck_step',
'test_backend_step',
@@ -56,6 +57,7 @@ def get_steps(edition, is_downstream=False):
codespell_step(),
shellcheck_step(),
lint_backend_step(edition=edition),
lint_frontend_step(),
test_backend_step(edition=edition),
test_frontend_step(),
build_backend_step(edition=edition, ver_mode=ver_mode, is_downstream=is_downstream),
+2
View File
@@ -1,6 +1,7 @@
load(
'scripts/drone/steps/lib.star',
'lint_backend_step',
'lint_frontend_step',
'codespell_step',
'shellcheck_step',
'build_backend_step',
@@ -47,6 +48,7 @@ def pr_pipelines(edition):
codespell_step(),
shellcheck_step(),
lint_backend_step(edition=edition),
lint_frontend_step(),
test_backend_step(edition=edition),
test_frontend_step(),
build_backend_step(edition=edition, ver_mode=ver_mode, variants=variants),
+2
View File
@@ -4,6 +4,7 @@ load(
'build_image',
'publish_image',
'lint_backend_step',
'lint_frontend_step',
'codespell_step',
'shellcheck_step',
'test_backend_step',
@@ -83,6 +84,7 @@ def get_steps(edition, ver_mode):
codespell_step(),
shellcheck_step(),
lint_backend_step(edition=edition),
lint_frontend_step(),
test_backend_step(edition=edition, tries=tries),
test_frontend_step(),
build_backend_step(edition=edition, ver_mode=ver_mode),
+19 -1
View File
@@ -391,7 +391,7 @@ def test_frontend_step():
'name': 'test-frontend',
'image': build_image,
'depends_on': [
'lint-backend',
'lint-frontend',
],
'environment': {
'TEST_MAX_WORKERS': '50%',
@@ -401,6 +401,24 @@ def test_frontend_step():
],
}
def lint_frontend_step():
return {
'name': 'lint-frontend',
'image': build_image,
'depends_on': [
'initialize',
],
'environment': {
'TEST_MAX_WORKERS': '50%',
},
'commands': [
'yarn run prettier:check',
'yarn run lint',
'yarn run typecheck',
'yarn run check-strict',
],
}
def test_a11y_frontend_step(edition, port=3001):
return {
'name': 'test-a11y-frontend' + enterprise2_suffix(edition),