IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

tests update

Browse Source
This commit is contained in:
Dominik Prokop 2024-01-03 12:15:50 +01:00
parent 44012b5cd6
commit 43f894236a
5 changed files with 69 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/features/dashboard-scene/utils/interactions.ts
View File

@ -150,7 +150,7 @@ export const DashboardInteractions = {
}; };
const reportDashboardInteraction: typeof reportInteraction = (name, properties) => { const reportDashboardInteraction: typeof reportInteraction = (name, properties) => {
const meta = isScenesContextSet ? { scenesView: true } : {}; const meta = isScenesContextSet ? { scenesView: true } : undefined;
if (properties) { if (properties) {
reportInteraction(`dashboards_${name}`, properties, meta); reportInteraction(`dashboards_${name}`, properties, meta);

14
public/app/features/dashboard/components/AddPanelButton/AddPanelMenu.test.tsx
View File

@ -110,7 +110,11 @@ it('creates new visualization when clicked on menu item Visualization', () => {
fireEvent.click(screen.getByRole('menuitem', { name: 'Visualization' })); fireEvent.click(screen.getByRole('menuitem', { name: 'Visualization' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_toolbar_add_clicked', { item: 'add_visualization' }); expect(reportInteraction).toHaveBeenCalledWith(
'dashboards_toolbar_add_clicked',
{ item: 'add_visualization' },
undefined
);
expect(locationService.partial).toHaveBeenCalled(); expect(locationService.partial).toHaveBeenCalled();
expect(onCreateNewPanel).toHaveBeenCalled(); expect(onCreateNewPanel).toHaveBeenCalled();
}); });
@ -122,7 +126,7 @@ it('creates new row when clicked on menu item Row', () => {
fireEvent.click(screen.getByRole('menuitem', { name: 'Row' })); fireEvent.click(screen.getByRole('menuitem', { name: 'Row' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_toolbar_add_clicked', { item: 'add_row' }); expect(reportInteraction).toHaveBeenCalledWith('dashboards_toolbar_add_clicked', { item: 'add_row' }, undefined);
expect(locationService.partial).not.toHaveBeenCalled(); expect(locationService.partial).not.toHaveBeenCalled();
expect(onCreateNewRow).toHaveBeenCalled(); expect(onCreateNewRow).toHaveBeenCalled();
}); });
@ -134,7 +138,11 @@ it('adds a library panel when clicked on menu item Import from library', () => {
fireEvent.click(screen.getByRole('menuitem', { name: 'Import from library' })); fireEvent.click(screen.getByRole('menuitem', { name: 'Import from library' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_toolbar_add_clicked', { item: 'import_from_library' }); expect(reportInteraction).toHaveBeenCalledWith(
'dashboards_toolbar_add_clicked',
{ item: 'import_from_library' },
undefined
);
expect(locationService.partial).not.toHaveBeenCalled(); expect(locationService.partial).not.toHaveBeenCalled();
expect(onAddLibraryPanel).toHaveBeenCalled(); expect(onAddLibraryPanel).toHaveBeenCalled();
}); });

30
public/app/features/dashboard/components/ShareModal/SharePublicDashboard/SharePublicDashboard.test.tsx
View File

@ -371,9 +371,13 @@ describe('SharePublic - Report interactions', () => {
await waitFor(() => { await waitFor(() => {
expect(reportInteraction).toHaveBeenCalledTimes(1); expect(reportInteraction).toHaveBeenCalledTimes(1);
expect(reportInteraction).toHaveBeenLastCalledWith('dashboards_sharing_public_time_picker_clicked', { expect(reportInteraction).toHaveBeenLastCalledWith(
enabled: !pubdashResponse.timeSelectionEnabled, 'dashboards_sharing_public_time_picker_clicked',
}); {
enabled: !pubdashResponse.timeSelectionEnabled,
},
undefined
);
}); });
}); });
@ -388,9 +392,13 @@ describe('SharePublic - Report interactions', () => {
await waitFor(() => { await waitFor(() => {
expect(reportInteraction).toHaveBeenCalledTimes(1); expect(reportInteraction).toHaveBeenCalledTimes(1);
expect(reportInteraction).toHaveBeenLastCalledWith('dashboards_sharing_public_annotations_clicked', { expect(reportInteraction).toHaveBeenLastCalledWith(
enabled: !pubdashResponse.annotationsEnabled, 'dashboards_sharing_public_annotations_clicked',
}); {
enabled: !pubdashResponse.annotationsEnabled,
},
undefined
);
}); });
}); });
it('reports interaction when pause is clicked', async () => { it('reports interaction when pause is clicked', async () => {
@ -402,9 +410,13 @@ describe('SharePublic - Report interactions', () => {
await waitFor(() => { await waitFor(() => {
expect(reportInteraction).toHaveBeenCalledTimes(1); expect(reportInteraction).toHaveBeenCalledTimes(1);
expect(reportInteraction).toHaveBeenLastCalledWith('dashboards_sharing_public_pause_clicked', { expect(reportInteraction).toHaveBeenLastCalledWith(
paused: pubdashResponse.isEnabled, 'dashboards_sharing_public_pause_clicked',
}); {
paused: pubdashResponse.isEnabled,
},
undefined
);
}); });
}); });
}); });

18
public/app/features/dashboard/dashgrid/DashboardEmpty.test.tsx
View File

@ -75,7 +75,11 @@ it('creates new visualization when clicked Add visualization', () => {
fireEvent.click(screen.getByRole('button', { name: 'Add visualization' })); fireEvent.click(screen.getByRole('button', { name: 'Add visualization' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_emptydashboard_clicked', { item: 'add_visualization' }); expect(reportInteraction).toHaveBeenCalledWith(
'dashboards_emptydashboard_clicked',
{ item: 'add_visualization' },
undefined
);
expect(locationService.partial).toHaveBeenCalled(); expect(locationService.partial).toHaveBeenCalled();
expect(onCreateNewPanel).toHaveBeenCalled(); expect(onCreateNewPanel).toHaveBeenCalled();
}); });
@ -87,7 +91,11 @@ it('open import dashboard when clicked Import dashboard', () => {
fireEvent.click(screen.getByRole('button', { name: 'Import dashboard' })); fireEvent.click(screen.getByRole('button', { name: 'Import dashboard' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_emptydashboard_clicked', { item: 'import_dashboard' }); expect(reportInteraction).toHaveBeenCalledWith(
'dashboards_emptydashboard_clicked',
{ item: 'import_dashboard' },
undefined
);
expect(onImportDashboard).toHaveBeenCalled(); expect(onImportDashboard).toHaveBeenCalled();
}); });
@ -98,7 +106,11 @@ it('adds a library panel when clicked Add library panel', () => {
fireEvent.click(screen.getByRole('button', { name: 'Add library panel' })); fireEvent.click(screen.getByRole('button', { name: 'Add library panel' }));
}); });
expect(reportInteraction).toHaveBeenCalledWith('dashboards_emptydashboard_clicked', { item: 'import_from_library' }); expect(reportInteraction).toHaveBeenCalledWith(
'dashboards_emptydashboard_clicked',
{ item: 'import_from_library' },
undefined
);
expect(locationService.partial).not.toHaveBeenCalled(); expect(locationService.partial).not.toHaveBeenCalled();
expect(onAddLibraryPanel).toHaveBeenCalled(); expect(onAddLibraryPanel).toHaveBeenCalled();
}); });

38
public/app/features/dashboard/utils/tracking.test.ts
View File

@ -35,22 +35,26 @@ describe('trackDashboardLoaded', () => {
trackDashboardLoaded(model, 16); trackDashboardLoaded(model, 16);
expect(reportInteractionSpy).toHaveBeenCalledWith('dashboards_init_dashboard_completed', { expect(reportInteractionSpy).toHaveBeenCalledWith(
uid: 'dashboard-123', 'dashboards_init_dashboard_completed',
title: 'Test Dashboard', {
schemaVersion: model.schemaVersion, // This value is based on public/app/features/dashboard/state/DashboardMigrator.ts#L81 uid: 'dashboard-123',
panels_count: 7, title: 'Test Dashboard',
variable_type_query_count: 2, schemaVersion: model.schemaVersion, // This value is based on public/app/features/dashboard/state/DashboardMigrator.ts#L81
variable_type_interval_count: 1, panels_count: 7,
version_before_migration: 16, variable_type_query_count: 2,
panel_type_row_count: 1, variable_type_interval_count: 1,
panel_type_stat_count: 1, version_before_migration: 16,
panel_type_graph_count: 2, panel_type_row_count: 1,
panel_type_timeseries_count: 1, panel_type_stat_count: 1,
'panel_type_grafana-worldmap-panel_count': 1, panel_type_graph_count: 2,
panel_type_geomap_count: 1, panel_type_timeseries_count: 1,
settings_nowdelay: '1m', 'panel_type_grafana-worldmap-panel_count': 1,
settings_livenow: true, panel_type_geomap_count: 1,
}); settings_nowdelay: '1m',
settings_livenow: true,
},
undefined
);
}); });
}); });