IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

snapshots: Close response body after error check

Browse Source
This commit is contained in:
Victor Cinaglia 2018-12-18 08:32:49 -05:00
parent 411d67cae7
commit 48fe92a945
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/api/dashboard_snapshot.go
View File

@ -51,13 +51,10 @@ func createExternalDashboardSnapshot(cmd m.CreateDashboardSnapshotCommand) (*Cre
} }
response, err := client.Post(setting.ExternalSnapshotUrl+"/api/snapshots", "application/json", bytes.NewBuffer(messageBytes)) response, err := client.Post(setting.ExternalSnapshotUrl+"/api/snapshots", "application/json", bytes.NewBuffer(messageBytes))
if response != nil {
defer response.Body.Close()
}
if err != nil { if err != nil {
return nil, err return nil, err
} }
defer response.Body.Close()
if response.StatusCode != 200 { if response.StatusCode != 200 {
return nil, fmt.Errorf("Create external snapshot response status code %d", response.StatusCode) return nil, fmt.Errorf("Create external snapshot response status code %d", response.StatusCode)
@ -159,14 +156,10 @@ func GetDashboardSnapshot(c *m.ReqContext) {
func deleteExternalDashboardSnapshot(externalUrl string) error { func deleteExternalDashboardSnapshot(externalUrl string) error {
response, err := client.Get(externalUrl) response, err := client.Get(externalUrl)
if response != nil {
defer response.Body.Close()
}
if err != nil { if err != nil {
return err return err
} }
defer response.Body.Close()
if response.StatusCode == 200 { if response.StatusCode == 200 {
return nil return nil